package/luajit: bump to version 2.1.x developpment version
diff mbox series

Message ID 1554216575-24134-1-git-send-email-jugurtha.belkalem@smile.fr
State Superseded
Headers show
Series
  • package/luajit: bump to version 2.1.x developpment version
Related show

Commit Message

Jugurtha BELKALEM April 2, 2019, 2:49 p.m. UTC
In order to integrate bcc (front end tool for eBPF) into buildroot
and testing it on a Raspberry PI 3; We need to upgrade the version
of luajit to 2.1.0 to support aarch64.

Currently, luajit aarch64_be support has not been tested.

Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
Cc: Francois Perrad <francois.perrad@gadz.org>
---
 package/luajit/Config.in   | 2 +-
 package/luajit/luajit.hash | 4 ++--
 package/luajit/luajit.mk   | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)

Comments

François Perrad April 3, 2019, 6:23 a.m. UTC | #1
Le mar. 2 avr. 2019 à 16:49, Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
a écrit :

> In order to integrate bcc (front end tool for eBPF) into buildroot
> and testing it on a Raspberry PI 3; We need to upgrade the version
> of luajit to 2.1.0 to support aarch64.
>
> Currently, luajit aarch64_be support has not been tested.
>
> Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
> Cc: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/luajit/Config.in   | 2 +-
>  package/luajit/luajit.hash | 4 ++--
>  package/luajit/luajit.mk   | 5 ++---
>  3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index 88c5bcb..9ecf6b4 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>         bool
> -       default y if BR2_i386 || \
> +       default y if BR2_i386 || BR2_aarch64 || \
>                 (BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
>                 BR2_powerpc || BR2_arm || BR2_armeb || \
>                 ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
> diff --git a/package/luajit/luajit.hash b/package/luajit/luajit.hash
> index 2081d12..b422bc9 100644
> --- a/package/luajit/luajit.hash
> +++ b/package/luajit/luajit.hash
> @@ -1,2 +1,2 @@
> -# Hashes from: http://luajit.org/download.html
> -md5 48353202cbcacab84ee41a5a70ea0a2c    LuaJIT-2.0.5.tar.gz
> +# Localy generated
> +sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd
> luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz
> diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> index 5b08a42..9a06691 100644
> --- a/package/luajit/luajit.mk
> +++ b/package/luajit/luajit.mk
> @@ -4,9 +4,8 @@
>  #
>
>  ################################################################################
>
> -LUAJIT_VERSION = 2.0.5
> -LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
> -LUAJIT_SITE = http://luajit.org/download
> +LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
>

Could you use the version 2.1.0-beta3 which is available (with its hash) on
http://luajit.org/download.html ?

François

+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))
>  LUAJIT_LICENSE = MIT
>  LUAJIT_LICENSE_FILES = COPYRIGHT
>
> --
> 2.7.4
>
>
<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 2 avr. 2019 à 16:49, Jugurtha BELKALEM &lt;<a href="mailto:jugurtha.belkalem@smile.fr">jugurtha.belkalem@smile.fr</a>&gt; a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">In order to integrate bcc (front end tool for eBPF) into buildroot<br>
and testing it on a Raspberry PI 3; We need to upgrade the version<br>
of luajit to 2.1.0 to support aarch64.<br>
<br>
Currently, luajit aarch64_be support has not been tested.<br>
<br>
Signed-off-by: Jugurtha BELKALEM &lt;<a href="mailto:jugurtha.belkalem@smile.fr" target="_blank">jugurtha.belkalem@smile.fr</a>&gt;<br>
Cc: Francois Perrad &lt;<a href="mailto:francois.perrad@gadz.org" target="_blank">francois.perrad@gadz.org</a>&gt;<br>
---<br>
 package/luajit/Config.in   | 2 +-<br>
 package/luajit/luajit.hash | 4 ++--<br>
 package/luajit/<a href="http://luajit.mk" rel="noreferrer" target="_blank">luajit.mk</a>   | 5 ++---<br>
 3 files changed, 5 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/package/luajit/Config.in b/package/luajit/Config.in<br>
index 88c5bcb..9ecf6b4 100644<br>
--- a/package/luajit/Config.in<br>
+++ b/package/luajit/Config.in<br>
@@ -1,6 +1,6 @@<br>
 config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS<br>
        bool<br>
-       default y if BR2_i386 || \<br>
+       default y if BR2_i386 || BR2_aarch64 || \<br>
                (BR2_x86_64 &amp;&amp; BR2_HOSTARCH=&#39;x86_64&#39;) || \<br>
                BR2_powerpc || BR2_arm || BR2_armeb || \<br>
                ((BR2_mips || BR2_mipsel) &amp;&amp; !BR2_MIPS_SOFT_FLOAT &amp;&amp; \<br>
diff --git a/package/luajit/luajit.hash b/package/luajit/luajit.hash<br>
index 2081d12..b422bc9 100644<br>
--- a/package/luajit/luajit.hash<br>
+++ b/package/luajit/luajit.hash<br>
@@ -1,2 +1,2 @@<br>
-# Hashes from: <a href="http://luajit.org/download.html" rel="noreferrer" target="_blank">http://luajit.org/download.html</a><br>
-md5 48353202cbcacab84ee41a5a70ea0a2c    LuaJIT-2.0.5.tar.gz<br>
+# Localy generated<br>
+sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz<br>
diff --git a/package/luajit/<a href="http://luajit.mk" rel="noreferrer" target="_blank">luajit.mk</a> b/package/luajit/<a href="http://luajit.mk" rel="noreferrer" target="_blank">luajit.mk</a><br>
index 5b08a42..9a06691 100644<br>
--- a/package/luajit/<a href="http://luajit.mk" rel="noreferrer" target="_blank">luajit.mk</a><br>
+++ b/package/luajit/<a href="http://luajit.mk" rel="noreferrer" target="_blank">luajit.mk</a><br>
@@ -4,9 +4,8 @@<br>
 #<br>
 ################################################################################<br>
<br>
-LUAJIT_VERSION = 2.0.5<br>
-LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz<br>
-LUAJIT_SITE = <a href="http://luajit.org/download" rel="noreferrer" target="_blank">http://luajit.org/download</a><br>
+LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1<br></blockquote><div><br></div><div>Could you use the version 2.1.0-beta3 which is available (with its hash) on <a href="http://luajit.org/download.html">http://luajit.org/download.html</a> ?</div><div><br></div><div>François<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))<br>
 LUAJIT_LICENSE = MIT<br>
 LUAJIT_LICENSE_FILES = COPYRIGHT<br>
<br>
-- <br>
2.7.4<br>
<br>
</blockquote></div></div></div></div></div></div>
Thomas Petazzoni April 3, 2019, 7:18 a.m. UTC | #2
Hello,

On Tue,  2 Apr 2019 16:49:35 +0200
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote:

> In order to integrate bcc (front end tool for eBPF) into buildroot
> and testing it on a Raspberry PI 3; We need to upgrade the version
> of luajit to 2.1.0 to support aarch64.
> 
> Currently, luajit aarch64_be support has not been tested.
> 
> Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
> Cc: Francois Perrad <francois.perrad@gadz.org>

Perhaps this can be done as part of a larger patch series that
introduces 'bcc' as well ? By that time, hopefully LuaJIT 2.1.0 will
have been released, and we'll be good ?

Thomas
Jugurtha BELKALEM April 3, 2019, 9:15 a.m. UTC | #3
Hi,

To answer the question of François : The luajit2.1.0-beta3 version in
http://luajit.org/download.html has not been changed since 2 years (last
change in May 2017), so I guess it is better to take a version which is up
to date.

To answer the question of Thamas : We have successfully tested bcc on a
raspberry PI 3, however; the purpose of this patch is to check that it does
not break the build process in buildroot (for example luajit2.1.0 is adding
support for aarch64; we need to ensure that it is safe).

Regards.
<div dir="ltr"><div dir="ltr"><div>Hi,</div><div><br></div><div>To answer the question of François : The luajit2.1.0-beta3 version in <a href="http://luajit.org/download.html">http://luajit.org/download.html</a> has not been changed since 2 years (last change in May 2017), so I guess it is better to take a version which is up to date.</div><div><br></div><div>To answer the question of Thamas : We have successfully tested bcc on a raspberry PI 3, however; the purpose of this patch is to check that it does not break the build process in buildroot (for example luajit2.1.0 is adding support for <span id="gmail-:28l.co" class="gmail-tL8wMe gmail-EMoHub" style="text-align:left" dir="ltr">aarch64; we need to ensure that it is safe</span>). <span id="gmail-:28l.co" class="gmail-tL8wMe gmail-EMoHub" style="text-align:left" dir="ltr"></span></div><div><br></div><div>Regards.  <br></div></div></div>
Arnout Vandecappelle April 14, 2019, 8:06 p.m. UTC | #4
[Please don't remove the quoted text entirely, but quote inline like below.]

On 03/04/2019 11:15, Jugurtha BELKALEM wrote:
> Hi,
> 
> To answer the question of François : The luajit2.1.0-beta3 version in
> http://luajit.org/download.html has not been changed since 2 years (last
> change in May 2017), so I guess it is better to take a version which is up
> to date.

 I feel a bit uncomfortable to bump a package to an unreleased version of a
project that is apparently not going anywhere (only a handful of commits in the
last year).

 Note that any issues are likely to be runtime issues. So it really depends on
the users of luajit (if such users even exist...) to decide if they're willing
to take that risk.


> To answer the question of Thamas : We have successfully tested bcc on a
> raspberry PI 3, however; the purpose of this patch is to check that it does
> not break the build process in buildroot (for example luajit2.1.0 is adding
> support for aarch64; we need to ensure that it is safe).

 So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
existing luajit version, only then you don't have aarch64 support?

 In that case, maybe it's better to make the version dependent on the
architecture, like we sometimes do for other packages. See for instance the arc
versions of binutils, gcc, gdb, glibc.

 Regards,
 Arnout
Romain Naour April 19, 2019, 7:55 a.m. UTC | #5
Hi Arnout,

Le 14/04/2019 à 22:06, Arnout Vandecappelle a écrit :
>  [Please don't remove the quoted text entirely, but quote inline like below.]
> 
> On 03/04/2019 11:15, Jugurtha BELKALEM wrote:
>> Hi,
>>
>> To answer the question of François : The luajit2.1.0-beta3 version in
>> http://luajit.org/download.html has not been changed since 2 years (last
>> change in May 2017), so I guess it is better to take a version which is up
>> to date.
> 
>  I feel a bit uncomfortable to bump a package to an unreleased version of a
> project that is apparently not going anywhere (only a handful of commits in the
> last year).

luajit2.1.0-beta3 doesn't seems a release version but it's packaged by Debian
testing, Fedora 26+, Ubuntu 18.04.

https://repology.org/project/luajit/versions

> 
>  Note that any issues are likely to be runtime issues. So it really depends on
> the users of luajit (if such users even exist...) to decide if they're willing
> to take that risk.

ok

> 
>> To answer the question of Thamas : We have successfully tested bcc on a
>> raspberry PI 3, however; the purpose of this patch is to check that it does
>> not break the build process in buildroot (for example luajit2.1.0 is adding
>> support for aarch64; we need to ensure that it is safe).
> 
>  So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
> existing luajit version, only then you don't have aarch64 support?

exact.

> 
>  In that case, maybe it's better to make the version dependent on the
> architecture, like we sometimes do for other packages. See for instance the arc
> versions of binutils, gcc, gdb, glibc.

Ok, maybe we should be careful with API break between 2.0.x and 2.1.x...

Best regards,
Romain

> 
>  Regards,
>  Arnout
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>

Patch
diff mbox series

diff --git a/package/luajit/Config.in b/package/luajit/Config.in
index 88c5bcb..9ecf6b4 100644
--- a/package/luajit/Config.in
+++ b/package/luajit/Config.in
@@ -1,6 +1,6 @@ 
 config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	bool
-	default y if BR2_i386 || \
+	default y if BR2_i386 || BR2_aarch64 || \
 		(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
 		BR2_powerpc || BR2_arm || BR2_armeb || \
 		((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
diff --git a/package/luajit/luajit.hash b/package/luajit/luajit.hash
index 2081d12..b422bc9 100644
--- a/package/luajit/luajit.hash
+++ b/package/luajit/luajit.hash
@@ -1,2 +1,2 @@ 
-# Hashes from: http://luajit.org/download.html
-md5 48353202cbcacab84ee41a5a70ea0a2c    LuaJIT-2.0.5.tar.gz
+# Localy generated
+sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz
diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
index 5b08a42..9a06691 100644
--- a/package/luajit/luajit.mk
+++ b/package/luajit/luajit.mk
@@ -4,9 +4,8 @@ 
 #
 ################################################################################
 
-LUAJIT_VERSION = 2.0.5
-LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
-LUAJIT_SITE = http://luajit.org/download
+LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))
 LUAJIT_LICENSE = MIT
 LUAJIT_LICENSE_FILES = COPYRIGHT