Patchwork [U-Boot] da850: add provision to use RMII for EMAC

login
register
mail settings
Submitter nagabhushana.netagunte@ti.com
Date July 28, 2011, 4:25 p.m.
Message ID <1311870338-18950-3-git-send-email-nagabhushana.netagunte@ti.com>
Download mbox | patch
Permalink /patch/107283/
State Changes Requested
Headers show

Comments

nagabhushana.netagunte@ti.com - July 28, 2011, 4:25 p.m.
From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>

Add provision to enable RMII support in configuration file.

Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
---
 include/configs/da850evm.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Detlev Zundel - July 29, 2011, 8:31 a.m.
Hi,

> From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
>
> Add provision to enable RMII support in configuration file.

What is that supposed to mean?  You are actually adding an "undef", so
nothing changes.  What are you trying to achieve?

> Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> ---
>  include/configs/da850evm.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
> index f7bf6be..92bab82 100644
> --- a/include/configs/da850evm.h
> +++ b/include/configs/da850evm.h
> @@ -123,6 +123,7 @@
>  #ifdef CONFIG_DRIVER_TI_EMAC
>  #define CONFIG_EMAC_MDIO_PHY_NUM	0
>  #define CONFIG_MII
> +#undef CONFIG_DRIVER_TI_EMAC_USE_RMII
>  #define CONFIG_BOOTP_DEFAULT
>  #define CONFIG_BOOTP_DNS
>  #define CONFIG_BOOTP_DNS2

Cheers
  Detlev
nagabhushana.netagunte@ti.com - Aug. 1, 2011, 9:46 a.m.
Hi Detlev,
Thanks for your comments. I will remove this patch as this patch doesn't make sense.
-Nag
On Fri, Jul 29, 2011 at 14:01:16, Detlev Zundel wrote:
> Hi,
> 
> > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> >
> > Add provision to enable RMII support in configuration file.
> 
> What is that supposed to mean?  You are actually adding an "undef", so nothing changes.  What are you trying to achieve?
> 
> > Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
> > Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> > ---
> >  include/configs/da850evm.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h 
> > index f7bf6be..92bab82 100644
> > --- a/include/configs/da850evm.h
> > +++ b/include/configs/da850evm.h
> > @@ -123,6 +123,7 @@
> >  #ifdef CONFIG_DRIVER_TI_EMAC
> >  #define CONFIG_EMAC_MDIO_PHY_NUM	0
> >  #define CONFIG_MII
> > +#undef CONFIG_DRIVER_TI_EMAC_USE_RMII
> >  #define CONFIG_BOOTP_DEFAULT
> >  #define CONFIG_BOOTP_DNS
> >  #define CONFIG_BOOTP_DNS2
> 
> Cheers
>   Detlev
> 
> --
> Ich hoffe, Sie verzeihen mir meine Leidenschaft.  Ich h├Ątte Ihnen Ihre auch gerne verziehen.
>                                      -- Dieter Hildebrandt
> --
> DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de
>

Patch

diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
index f7bf6be..92bab82 100644
--- a/include/configs/da850evm.h
+++ b/include/configs/da850evm.h
@@ -123,6 +123,7 @@ 
 #ifdef CONFIG_DRIVER_TI_EMAC
 #define CONFIG_EMAC_MDIO_PHY_NUM	0
 #define CONFIG_MII
+#undef CONFIG_DRIVER_TI_EMAC_USE_RMII
 #define CONFIG_BOOTP_DEFAULT
 #define CONFIG_BOOTP_DNS
 #define CONFIG_BOOTP_DNS2