Patchwork [U-Boot] da850: add cache management support in config file

login
register
mail settings
Submitter nagabhushana.netagunte@ti.com
Date July 28, 2011, 4:25 p.m.
Message ID <1311870338-18950-2-git-send-email-nagabhushana.netagunte@ti.com>
Download mbox | patch
Permalink /patch/107280/
State Accepted
Commit bd65d006a6088bcb857e079447d7549e2cd7054d
Headers show

Comments

nagabhushana.netagunte@ti.com - July 28, 2011, 4:25 p.m.
From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>

add support for cache management in config file. This is
needed as per new cache management framework. da850 doesnt
support I-CACHE, D-CACHE or L2-CACHE usage which is indicated
by following definitions,

1. CONFIG_SYS_ICACHE_OFF
2. CONFIG_SYS_DCACHE_OFF
3. CONFIG_SYS_L2CACHE_OFF

Signed-off-by: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
Signed-off-by: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
---
 include/configs/da850evm.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Detlev Zundel - July 29, 2011, 8:26 a.m.
Hi,

> From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
>
> add support for cache management in config file. This is
> needed as per new cache management framework. da850 doesnt
> support I-CACHE, D-CACHE or L2-CACHE usage which is indicated
> by following definitions,
>
> 1. CONFIG_SYS_ICACHE_OFF
> 2. CONFIG_SYS_DCACHE_OFF
> 3. CONFIG_SYS_L2CACHE_OFF

This commit message makes no sense for me.  You "add support" for
something which essentially is "not supported" as you say.  If you are
trying to fix compile problems, then please say so.

Cheers
  Detlev
nagabhushana.netagunte@ti.com - Aug. 1, 2011, 9:44 a.m.
Detlev,
Thanks for your comments, I will make appropriate changes to 'commit' message.
-Nag
On Fri, Jul 29, 2011 at 13:56:32, Detlev Zundel wrote:
> Hi,
> 
> > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com>
> >
> > add support for cache management in config file. This is needed as per 
> > new cache management framework. da850 doesnt support I-CACHE, D-CACHE 
> > or L2-CACHE usage which is indicated by following definitions,
> >
> > 1. CONFIG_SYS_ICACHE_OFF
> > 2. CONFIG_SYS_DCACHE_OFF
> > 3. CONFIG_SYS_L2CACHE_OFF
> 
> This commit message makes no sense for me.  You "add support" for something which essentially is "not supported" as you say.  If you are trying to fix compile problems, then please say so.
> 
> Cheers
>   Detlev
> 
> --
> ... that every year or so they're going to give you a new release full of 50 000  additional lines of code all  written  by monkeys.  Because
> they generally follow  the  ``million monkeys typing,   and eventually
> they'll come up with something useful'' school of system development.
> 	                                    -- Richard M. Stallman
> --
> DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu@denx.de
>

Patch

diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
index bbb5a9b..fdcc6e3 100644
--- a/include/configs/da850evm.h
+++ b/include/configs/da850evm.h
@@ -42,6 +42,9 @@ 
 #define CONFIG_SYS_HZ			1000
 #define CONFIG_SKIP_LOWLEVEL_INIT
 #define CONFIG_SYS_TEXT_BASE		0xc1080000
+#define CONFIG_SYS_ICACHE_OFF
+#define CONFIG_SYS_DCACHE_OFF
+#define CONFIG_SYS_L2CACHE_OFF
 
 /*
  * Memory Info