Message ID | 1311870338-18950-7-git-send-email-nagabhushana.netagunte@ti.com |
---|---|
State | Changes Requested |
Headers | show |
Dear nagabhushana.netagunte@ti.com, In message <1311870338-18950-7-git-send-email-nagabhushana.netagunte@ti.com> you wrote: > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com> > > TX and RX channel numbers programmed as '1' during EMAC teardown initialization > is wrong. This patch fixes the same by setting channel number to '0' which is > used by U-boot. Is this set of patches in any specific order? It appaers so, as it seems I cannot apply them in random order. But then, you don't provide any numbering in the Subject: or elsewhere, so how should we know? NAK for the whole set of patches. Please resubmit with proper numbering. Best regards, Wolfgang Denk
Thanks Denk for the comments. Even though all the patches are separate w.r.t features, they have inter-dependency w.r.t applying. To make it easy for applying, I will send it as Single series with a cover letter as they are all related to da850. I hope That is OK with you. Thanks, Nagabhushana On Fri, Jul 29, 2011 at 00:12:12, Wolfgang Denk wrote: > Dear nagabhushana.netagunte@ti.com, > > In message <1311870338-18950-7-git-send-email-nagabhushana.netagunte@ti.com> you wrote: > > From: Nagabhushana Netagunte <nagabhushana.netagunte@ti.com> > > > > TX and RX channel numbers programmed as '1' during EMAC teardown > > initialization is wrong. This patch fixes the same by setting channel > > number to '0' which is used by U-boot. > > Is this set of patches in any specific order? It appaers so, as it seems I cannot apply them in random order. > > But then, you don't provide any numbering in the Subject: or elsewhere, so how should we know? > > > NAK for the whole set of patches. Please resubmit with proper numbering. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de As in certain cults it is possible to kill a process if you know its > true name. -- Ken Thompson and Dennis M. Ritchie >
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 66c0d13..c0b8929 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -457,7 +457,7 @@ static void davinci_eth_ch_teardown(int ch) if (ch == EMAC_CH_TX) { /* Init TX channel teardown */ - writel(1, &adap_emac->TXTEARDOWN); + writel(0, &adap_emac->TXTEARDOWN); do { /* * Wait here for Tx teardown completion interrupt to @@ -476,7 +476,7 @@ static void davinci_eth_ch_teardown(int ch) writel(0, &adap_emac->TX0HDP); } else { /* Init RX channel teardown */ - writel(1, &adap_emac->RXTEARDOWN); + writel(0, &adap_emac->RXTEARDOWN); do { /* * Wait here for Rx teardown completion interrupt to