Patchwork PR45450: disable legality check after an openscop read

login
register
mail settings
Submitter Sebastian Pop
Date July 27, 2011, 2:37 p.m.
Message ID <1311777435-11797-1-git-send-email-sebpop@gmail.com>
Download mbox | patch
Permalink /patch/107093/
State New
Headers show

Comments

Sebastian Pop - July 27, 2011, 2:37 p.m.
Hi,

I will commit this patch to trunk after regstrap.

Sebastian

2011-07-23  Sebastian Pop  <sebastian.pop@amd.com>

	PR middle-end/45450
	* graphite-poly.c (apply_poly_transforms): Disable legality check
	after an openscop read.
---
 gcc/ChangeLog       |    6 ++++++
 gcc/graphite-poly.c |    6 +++++-
 2 files changed, 11 insertions(+), 1 deletions(-)
H.J. Lu - July 27, 2011, 6:23 p.m.
On Wed, Jul 27, 2011 at 7:37 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> I will commit this patch to trunk after regstrap.
>
> Sebastian
>
> 2011-07-23  Sebastian Pop  <sebastian.pop@amd.com>
>
>        PR middle-end/45450
>        * graphite-poly.c (apply_poly_transforms): Disable legality check
>        after an openscop read.

One of your changes from revision 176836-176838 may have caused:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49876

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 266dd28..4dbca71 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@ 
 2011-07-23  Sebastian Pop  <sebastian.pop@amd.com>
 
+	PR middle-end/45450
+	* graphite-poly.c (apply_poly_transforms): Disable legality check
+	after an openscop read.
+
+2011-07-23  Sebastian Pop  <sebastian.pop@amd.com>
+
 	PR middle-end/47691
 	* graphite-clast-to-gimple.c (translate_clast_user): Update use of
 	copy_bb_and_scalar_dependences.
diff --git a/gcc/graphite-poly.c b/gcc/graphite-poly.c
index bfdbc9f..db5b0cb 100644
--- a/gcc/graphite-poly.c
+++ b/gcc/graphite-poly.c
@@ -738,7 +738,11 @@  apply_poly_transforms (scop_p scop)
       graphite_file = init_graphite_in_file (file_scop_number);
       transform_done |= graphite_read_scop_file (graphite_file, scop);
 
-      if (!graphite_legal_transform (scop))
+      /* We cannot check for the legality of the transform here: there
+	 are cases where graphite_legal_transform cannot determine the
+	 dependence at compile time.  For an example, see the
+	 explanation of why http://gcc.gnu.org/PR45450 is invalid.  */
+      if (0 && !graphite_legal_transform (scop))
 	fatal_error ("the graphite file read for scop %d does not contain a legal transform",
 		     (int) file_scop_number);