Patchwork [1/6] VMDK: enable twoGbMaxExtentFlat

login
register
mail settings
Submitter Feiran Zheng
Date July 27, 2011, 9:27 a.m.
Message ID <1311758866-30029-2-git-send-email-famcool@gmail.com>
Download mbox | patch
Permalink /patch/107002/
State New
Headers show

Comments

Feiran Zheng - July 27, 2011, 9:27 a.m.
Enable the createType 'twoGbMaxExtentFlat'. The supporting code is
already in.

Signed-off-by: Fam Zheng <famcool@gmail.com>
---
 block/vmdk.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Feiran Zheng - July 29, 2011, 1:42 a.m.
Sorry, I missed one line in this patch. Will fix it in V2.

On Wed, Jul 27, 2011 at 5:27 PM, Fam Zheng <famcool@gmail.com> wrote:
> Enable the createType 'twoGbMaxExtentFlat'. The supporting code is
> already in.
>
> Signed-off-by: Fam Zheng <famcool@gmail.com>
> ---
>  block/vmdk.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 37478d2..9e6c67a 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -551,7 +551,8 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int flags)
>     if (vmdk_parse_description(buf, "createType", ct, sizeof(ct))) {
>         return -EINVAL;
>     }
> -    if (strcmp(ct, "monolithicFlat")) {
> +    if (strcmp(ct, "monolithicFlat") &&
> +        strcmp(ct, "twoGbMaxExtentFlat")) {
>         fprintf(stderr,
>                 "VMDK: Not supported image type \"%s\""".\n", ct);
>         return -ENOTSUP;
>

Patch

diff --git a/block/vmdk.c b/block/vmdk.c
index 37478d2..9e6c67a 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -551,7 +551,8 @@  static int vmdk_open_desc_file(BlockDriverState *bs, int flags)
     if (vmdk_parse_description(buf, "createType", ct, sizeof(ct))) {
         return -EINVAL;
     }
-    if (strcmp(ct, "monolithicFlat")) {
+    if (strcmp(ct, "monolithicFlat") &&
+        strcmp(ct, "twoGbMaxExtentFlat")) {
         fprintf(stderr,
                 "VMDK: Not supported image type \"%s\""".\n", ct);
         return -ENOTSUP;