| Message ID | 20190329165803.8651-1-jack@suse.cz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | e2fsprogs: Fix autoheader failure | expand |
On Fri, Mar 29, 2019 at 05:58:03PM +0100, Jan Kara wrote: > Autoheader reports: > > autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS > autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description]) > autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY > > so provide appropriate descriptions for the defines. > > Signed-off-by: Jan Kara <jack@suse.cz> Thanks, apologies for failing to push out the e2fsprogs fix out to git earlier, but this problem has already been fixed by commit f72ea2deb0d8. Cheers, - Ted
On Fri 29-03-19 21:48:57, Theodore Ts'o wrote: > On Fri, Mar 29, 2019 at 05:58:03PM +0100, Jan Kara wrote: > > Autoheader reports: > > > > autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS > > autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description]) > > autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY > > > > so provide appropriate descriptions for the defines. > > > > Signed-off-by: Jan Kara <jack@suse.cz> > > Thanks, apologies for failing to push out the e2fsprogs fix out to git > earlier, but this problem has already been fixed by commit > f72ea2deb0d8. No problem :). I was just packaging latest e2fsprogs release and stumbled upon this... Honza
On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote: > > No problem :). I was just packaging latest e2fsprogs release and stumbled > upon this... If you are packaging the e2fsprogs v1.45, I suggest you either (a) hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope to get out fairly soon, since by packaing 1.45 for Debian unstable, we've gotten many useful bug reports and as you can see, there are a lot of e2scrub fixes that are queued up for the next release. - Ted
On Mon 01-04-19 09:24:12, Theodore Ts'o wrote: > On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote: > > > > No problem :). I was just packaging latest e2fsprogs release and stumbled > > upon this... > > If you are packaging the e2fsprogs v1.45, I suggest you either (a) > hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope > to get out fairly soon, since by packaing 1.45 for Debian unstable, > we've gotten many useful bug reports and as you can see, there are a > lot of e2scrub fixes that are queued up for the next release. Thanks for info! I did package e2scrub but so far disabled installing any of crond files, systemd files, or udev rules so it should be harmless unless someone manually runs it... Honza
On Mon, Apr 01, 2019 at 04:38:59PM +0200, Jan Kara wrote: > On Mon 01-04-19 09:24:12, Theodore Ts'o wrote: > > On Mon, Apr 01, 2019 at 10:05:48AM +0200, Jan Kara wrote: > > > > > > No problem :). I was just packaging latest e2fsprogs release and stumbled > > > upon this... > > > > If you are packaging the e2fsprogs v1.45, I suggest you either (a) > > hold back on packaging e2scrub, or (b) wait for 1.45.1, which I hope > > to get out fairly soon, since by packaing 1.45 for Debian unstable, > > we've gotten many useful bug reports and as you can see, there are a > > lot of e2scrub fixes that are queued up for the next release. > > Thanks for info! I did package e2scrub but so far disabled installing any > of crond files, systemd files, or udev rules so it should be harmless > unless someone manually runs it... I did pretty much the same thing for rawhide and I do plan to enable the whole thing with the next update. Thanks! -Lukas > > Honza > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR
diff --git a/configure.ac b/configure.ac index 248b291dd0d2..290f93ebdf2f 100644 --- a/configure.ac +++ b/configure.ac @@ -1119,9 +1119,9 @@ dnl the functions added after migrating that library to util-linux dnl if test -n "$BLKID_CMT"; then AC_CHECK_LIB(blkid, blkid_probe_get_topology, - AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1)) + AC_DEFINE(HAVE_BLKID_PROBE_GET_TOPOLOGY, 1, [Define to 1 if blkid library provides blkid_probe_get_topology])) AC_CHECK_LIB(blkid, blkid_probe_enable_partitions, - AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1)) + AC_DEFINE(HAVE_BLKID_PROBE_ENABLE_PARTITIONS, 1, [Define to 1 if blkid library provides blkid_probe_enable_partitions])) fi dnl if test -n "$DLOPEN_LIB" ; then
Autoheader reports: autoheader: warning: missing template: HAVE_BLKID_PROBE_ENABLE_PARTITIONS autoheader: Use AC_DEFINE([HAVE_BLKID_PROBE_ENABLE_PARTITIONS], [], [Description]) autoheader: warning: missing template: HAVE_BLKID_PROBE_GET_TOPOLOGY so provide appropriate descriptions for the defines. Signed-off-by: Jan Kara <jack@suse.cz> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)