Patchwork [1/1] Fix typo for qmp-commands.hx. Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

login
register
mail settings
Submitter Zhi Yong Wu
Date July 27, 2011, 6:32 a.m.
Message ID <1311748376-5147-2-git-send-email-wuzhy@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/106986/
State New
Headers show

Comments

Zhi Yong Wu - July 27, 2011, 6:32 a.m.
---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - July 27, 2011, 8:03 a.m.
On Wed, Jul 27, 2011 at 7:32 AM, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> wrote:
> ---
>  qmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, merged into the trivial-patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

A few tips on sending patches:

If there is only one patch, a cover letter email is usually not
necessary.  Just send a single patch email.

Usually the commit message should be "<subsystem>: <short_message>".
Your cover letter subject was fine ("qmp: fix typo for
qmp-commands.hx") and should be used as the subject for this patch.

In this particular patch email your Signed-off-by is in the email
subject, it should be at the bottom of the commit description.

If in doubt about the formatting of patch emails, I suggest sending to
yourself first and looking at the generated emails to check that they
come out alright.

I have applied this fix-ups to the commit:
http://repo.or.cz/w/qemu/stefanha.git/commitdiff/0b2e110b0689e9250da78c3bf7a1a67b378856c9

Stefan

Patch

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 92c5c3a..d7352ae 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -42,7 +42,7 @@  and we're going to establish a deprecation policy for badly defined commands.
 
 If you're planning to adopt QMP, please observe the following:
 
-    1. The deprecation policy will take efect and be documented soon, please
+    1. The deprecation policy will take effect and be documented soon, please
        check the documentation of each used command as soon as a new release of
        QEMU is available