From patchwork Fri Mar 29 02:13:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 1068994 X-Patchwork-Delegate: richard@nod.at Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dDb7Gka0"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=alliedtelesis.co.nz header.i=@alliedtelesis.co.nz header.b="oDLeOZt7"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Vlf76xqpz9sPj for ; Fri, 29 Mar 2019 13:13:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L5+J4pHo4Pr9A3GGmD3Qm48ruKQA4g6P8fCn5W9qUWA=; b=dDb7Gka09p5FUC +I/y3qaagzn6OAExJ2IvZY2FJzBj8d8UQkoRECFuGrxW+1epuO8kT3KhMAyJgIGRu548qxVrP1ltm BuraFt3RFzBUMEI0/8SvjmGGDCLNTAlaxZMWcN9Ja044W2CcdwOUATIkS9Fv0vH5z+Dy+TsAy0jKH DTBWK67natcusfkCXrIp0oScz2rxvGYxsx52dtaVIwym8LGbtWf2LveryzQZiUSLBmlBiOQMaQnRR Fyc/D5YTdH2irjQ6pbAGqD/r8OcejCH26Utc39i0e1rw1ann7PiUEiBIYPpv6LHBlHf0lVuvjOVOg r7ffcpvxusGP22tRSx8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9h1e-0005ZC-P8; Fri, 29 Mar 2019 02:13:46 +0000 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9h1Y-0005MU-IR for linux-mtd@lists.infradead.org; Fri, 29 Mar 2019 02:13:45 +0000 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 10645886BF; Fri, 29 Mar 2019 15:13:35 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1553825615; bh=qXin5++Sh+VhWuTQR9KLZkGJA2wyYE/7eLeYglda5aE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oDLeOZt70VOuvpqL7FxS1O9nQi262UStlswTF/hZgw51g+YxYk0gbRexJCCSv0JMV 2wBuP2dWjtLhjgigKGq+qWgpPZfQHwK9kN0id8rxh5HjExa7sy8kReFY0GOedbDFMR F9BJsep35W7LEFAZUQ89i+Yo79cpX+4izCzMcZVBv3Nvek3M7QmjyUQPzVfCGHKUfw nMlGoRDhHxXCMBlMdqHtn7SH6gIMniB6tRQhkJt1Zko1u0soUSQy9esU1rSFogLfja Q0iKJaowMHRYtaa8Z69bwZ2Kq7WMD0ytJ8D2tXS1t9kOK+lQSKMQXIp4zahIWQQ2hP lUbdQblsYZG/A== Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121) id ; Fri, 29 Mar 2019 15:13:33 +1300 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by smtp (Postfix) with ESMTP id F1B4913EC56; Fri, 29 Mar 2019 15:13:34 +1300 (NZDT) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id D7AFA1E1124; Fri, 29 Mar 2019 15:13:34 +1300 (NZDT) From: Chris Packham To: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, marek.vasut@gmail.com, richard@nod.at, robh+dt@kernel.org, mark.rutland@arm.com Subject: [PATCH v2 1/2] mtd: maps: physmap: Store gpio_values correctly Date: Fri, 29 Mar 2019 15:13:21 +1300 Message-Id: <20190329021322.6833-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190329021322.6833-1-chris.packham@alliedtelesis.co.nz> References: <20190329021322.6833-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 x-atlnz-ls: pat X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_191341_475924_40F1574E X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [202.36.163.20 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chris Packham , linux-mtd@lists.infradead.org, Boris Brezillon Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When the gpio-addr-flash.c driver was merged with physmap-core.c the code to store the current gpio_values was lost. This meant that once a gpio was asserted it was never de-asserted. Fix this by storing the current offset in gpio_values like the old driver used to. Fixes: commit ba32ce95cbd9 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c") Cc: Signed-off-by: Chris Packham Reviewed-by: Boris Brezillon --- Changes in v2: - Cc stable, add Boris' review drivers/mtd/maps/physmap-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c index d9a3e4bebe5d..21b556afc305 100644 --- a/drivers/mtd/maps/physmap-core.c +++ b/drivers/mtd/maps/physmap-core.c @@ -132,6 +132,8 @@ static void physmap_set_addr_gpios(struct physmap_flash_info *info, gpiod_set_value(info->gpios->desc[i], !!(BIT(i) & ofs)); } + + info->gpio_values = ofs; } #define win_mask(order) (BIT(order) - 1)