[v2,1/2] mtd: maps: physmap: Store gpio_values correctly
diff mbox series

Message ID 20190329021322.6833-2-chris.packham@alliedtelesis.co.nz
State Accepted
Delegated to: Richard Weinberger
Headers show
  • mtd: physmap: Using gpio-addrs
Related show

Commit Message

Chris Packham March 29, 2019, 2:13 a.m. UTC
When the gpio-addr-flash.c driver was merged with physmap-core.c the
code to store the current gpio_values was lost. This meant that once a
gpio was asserted it was never de-asserted. Fix this by storing the
current offset in gpio_values like the old driver used to.

Fixes: commit ba32ce95cbd9 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Changes in v2:
- Cc stable, add Boris' review

 drivers/mtd/maps/physmap-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff mbox series

diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c
index d9a3e4bebe5d..21b556afc305 100644
--- a/drivers/mtd/maps/physmap-core.c
+++ b/drivers/mtd/maps/physmap-core.c
@@ -132,6 +132,8 @@  static void physmap_set_addr_gpios(struct physmap_flash_info *info,
 		gpiod_set_value(info->gpios->desc[i], !!(BIT(i) & ofs));
+	info->gpio_values = ofs;
 #define win_mask(order)		(BIT(order) - 1)