From patchwork Tue Jul 26 16:39:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 106892 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 67289B6F7C for ; Wed, 27 Jul 2011 02:39:47 +1000 (EST) Received: from localhost ([::1]:43066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlkfV-0003Fl-5K for incoming@patchwork.ozlabs.org; Tue, 26 Jul 2011 12:39:41 -0400 Received: from eggs.gnu.org ([140.186.70.92]:58952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlkfQ-0003Fg-Bb for qemu-devel@nongnu.org; Tue, 26 Jul 2011 12:39:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlkfP-000649-0n for qemu-devel@nongnu.org; Tue, 26 Jul 2011 12:39:36 -0400 Received: from mout.perfora.net ([74.208.4.194]:55420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlkfO-00063p-QB; Tue, 26 Jul 2011 12:39:34 -0400 Received: from localhost.localdomain ([32.97.110.59]) by mrelay.perfora.net (node=mrus4) with ESMTP (Nemesis) id 0McV8y-1R3HY72xUW-00IVOb; Tue, 26 Jul 2011 12:39:33 -0400 From: Michael Roth To: qemu-devel@nongnu.org Date: Tue, 26 Jul 2011 11:39:24 -0500 Message-Id: <1311698364-32395-1-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <4E2EED1E.6030402@linux.vnet.ibm.com> References: <4E2EED1E.6030402@linux.vnet.ibm.com> X-Provags-ID: V02:K0:VwvqjCz7XPoDSeBYGPYQch7grMPbzpQ4oiPJneL1C4C PKqvAMinGS8IlpIxmjuory2C6myH1lVoK2k8Rf64CDCiOFfU1P NHE4Uw4OT7eLT7jIvZmtCTk2UjHCIyWWJsBHyD9B7NmC3561GB Wg++lBS9DydJlDSg+SfkBNfRhTfzo3tY9vzut3uUl71uwDoXkG rsUu/Eg/Rh77GXSZ3HGdMfWyGlKFjYnvkkjy2NTYdE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.208.4.194 Cc: qemu-trivial@nongnu.org, aliguori@us.ibm.com, stefanb@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH] Makefile: add missing deps on $(GENERATED_HEADERS) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This fixes a build issue with make -j6+ due to qapi-generated files being built before $(GENERATED_HEADERS) have been created. Signed-off-by: Michael Roth Tested-by: Stefan Berger --- Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index daa3aa0..0a31633 100644 --- a/Makefile +++ b/Makefile @@ -192,8 +192,10 @@ test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-qapi-types test-qmp-commands: test-qmp-commands.o qfloat.o qint.o qdict.o qstring.o qlist.o qbool.o $(qapi-obj-y) error.o osdep.o qemu-malloc.o $(oslib-obj-y) qjson.o json-streamer.o json-lexer.o json-parser.o qerror.o qemu-error.o qemu-tool.o $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o $(qapi-dir)/test-qmp-marshal.o module.o QGALIB=qga/guest-agent-command-state.o qga/guest-agent-commands.o +QGALIB_GEN=$(addprefix $(qapi-dir)/, qga-qapi-types.c qga-qapi-types.h qga-qapi-visit.c qga-qmp-marshal.c) -qemu-ga.o: $(addprefix $(qapi-dir)/, qga-qapi-types.c qga-qapi-types.h qga-qapi-visit.c qga-qmp-marshal.c) $(qapi-obj-y) +$(QGALIB_GEN): $(GENERATED_HEADERS) +$(QGALIB) qemu-ga.o: $(QGALIB_GEN) $(qapi-obj-y) qemu-ga$(EXESUF): qemu-ga.o $(QGALIB) qemu-tool.o qemu-error.o error.o $(oslib-obj-y) $(trace-obj-y) $(block-obj-y) $(qobject-obj-y) $(version-obj-y) $(qapi-obj-y) qemu-timer-common.o qemu-sockets.o module.o qapi/qmp-dispatch.o qapi/qmp-registry.o $(qapi-dir)/qga-qapi-visit.o $(qapi-dir)/qga-qapi-types.o $(qapi-dir)/qga-qmp-marshal.o QEMULIBS=libhw32 libhw64 libuser libdis libdis-user