| Message ID | 20190328143214.GP32590@kadam |
|---|---|
| State | Deferred |
| Headers | show |
| Series | phy: tegra: xusb: testing the wrong variable in probe() | expand |
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c index 11ad6e4e4711..a627fe0b8e54 100644 --- a/drivers/phy/tegra/xusb-tegra186.c +++ b/drivers/phy/tegra/xusb-tegra186.c @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl, } priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk"); - if (IS_ERR(usb2->clk)) { - err = PTR_ERR(usb2->clk); + if (IS_ERR(priv->usb2_trk_clk)) { + err = PTR_ERR(priv->usb2_trk_clk); dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err); goto unregister; }
The "usb2->clk" pointer is not an error pointer. We meant to test "priv->usb2_trk_clk" instead. Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/phy/tegra/xusb-tegra186.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)