| Message ID | 20190328131349.18838-4-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: Failure path fixes | expand |
On 3/28/2019 6:43 PM, Geert Uytterhoeven wrote: > gpiochip_free_hogs() was always called from gpiochip_remove(), not > of_gpiochip_remove(). It is now also called from the failure patch in > gpiochip_add_data_with_key(). > > Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Looks good to be removed. Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> -Mukesh > --- > drivers/gpio/gpiolib.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index ed4da07effe0ac40..ec326bd84b1f1c50 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -4449,8 +4449,6 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, > /** > * gpiochip_free_hogs - Scan gpio-controller chip and release GPIO hog > * @chip: gpio chip to act on > - * > - * This is only used by of_gpiochip_remove to free hogged gpios > */ > static void gpiochip_free_hogs(struct gpio_chip *chip) > {
On Thu, Mar 28, 2019 at 2:13 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > gpiochip_free_hogs() was always called from gpiochip_remove(), not > of_gpiochip_remove(). It is now also called from the failure patch in > gpiochip_add_data_with_key(). > > Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Patch applied for v5.2. Yours, Linus Walleij
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index ed4da07effe0ac40..ec326bd84b1f1c50 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4449,8 +4449,6 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, /** * gpiochip_free_hogs - Scan gpio-controller chip and release GPIO hog * @chip: gpio chip to act on - * - * This is only used by of_gpiochip_remove to free hogged gpios */ static void gpiochip_free_hogs(struct gpio_chip *chip) {
gpiochip_free_hogs() was always called from gpiochip_remove(), not of_gpiochip_remove(). It is now also called from the failure patch in gpiochip_add_data_with_key(). Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpio/gpiolib.c | 2 -- 1 file changed, 2 deletions(-)