Patchwork [PR43597,ARM,TESTCASE]

login
register
mail settings
Submitter Tom de Vries
Date July 25, 2011, 4:11 p.m.
Message ID <4E2D95C3.8030705@codesourcery.com>
Download mbox | patch
Permalink /patch/106714/
State New
Headers show

Comments

Tom de Vries - July 25, 2011, 4:11 p.m.
Hi,

thanks for the review.

On 07/18/2011 03:19 PM, Richard Earnshaw wrote:
> On 18/07/11 12:09, Tom de Vries wrote:
>> Hi,
>>
>> PR43597 was fixed by http://gcc.gnu.org/viewcvs?view=revision&revision=172032.
>>
>> This patch adds a testcase.
>>
>> OK for trunk?
>>
>> Thanks,
>> - Tom
>>
>> 2011-07-18  Tom de Vries  <tom@codesourcery.com>
>>
>>     PR target/43597
>>     * gcc.target/arm/pr43597.c: New test.
>>
>>
> 
> No, don't pass -mthumb through dg-options unless you're using something
> like require-effective-target.
> 

OK, I see.

> In this case the post-compile tests are all gated on thumb2.  So why not
> make the whole test just require arm_thumb2_ok?
> 
> R.
> 

Done. OK for trunk?

Thanks,
- Tom

2011-07-25  Tom de Vries  <tom@codesourcery.com>

	PR target/43597
	* gcc.target/arm/pr43597.c: New test.
Tom de Vries - July 31, 2011, 10:18 a.m.
On 07/25/2011 07:11 PM, Tom de Vries wrote:
> Hi,
> 
> thanks for the review.
> 
> On 07/18/2011 03:19 PM, Richard Earnshaw wrote:
>> On 18/07/11 12:09, Tom de Vries wrote:
>>> Hi,
>>>
>>> PR43597 was fixed by http://gcc.gnu.org/viewcvs?view=revision&revision=172032.
>>>
>>> This patch adds a testcase.
>>>
>>> OK for trunk?
>>>
>>> Thanks,
>>> - Tom
>>>
>>> 2011-07-18  Tom de Vries  <tom@codesourcery.com>
>>>
>>>     PR target/43597
>>>     * gcc.target/arm/pr43597.c: New test.
>>>
>>>
>>
>> No, don't pass -mthumb through dg-options unless you're using something
>> like require-effective-target.
>>
> 
> OK, I see.
> 
>> In this case the post-compile tests are all gated on thumb2.  So why not
>> make the whole test just require arm_thumb2_ok?
>>
>> R.
>>
> 
> Done. OK for trunk?
> 

Ping. http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02173.html OK for trunk?

Thanks,
-Tom

> 2011-07-25  Tom de Vries  <tom@codesourcery.com>
> 
> 	PR target/43597
> 	* gcc.target/arm/pr43597.c: New test.
Tom de Vries - Aug. 17, 2011, 9:34 a.m.
Hi Richard,

Ping. http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02173.html OK for trunk?

Thanks,
- Tom
Ramana Radhakrishnan - Aug. 17, 2011, 10:57 a.m.
On 17 August 2011 10:34, Tom de Vries <vries@codesourcery.com> wrote:
>
> Ping. http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02173.html OK for trunk?

This is OK.

Ramana


>
> Thanks,
> - Tom
>

Patch

Index: gcc.target/arm/pr43597.c
===================================================================
--- gcc.target/arm/pr43597.c	(revision 0)
+++ gcc.target/arm/pr43597.c	(revision 0)
@@ -0,0 +1,28 @@ 
+/* { dg-do assemble } */
+/* { dg-options "-Os -save-temps -mthumb" } */
+/* { dg-require-effective-target arm_thumb2_ok } */
+
+extern int bar ();
+extern void bar2 (int);
+
+int
+foo4 ()
+{
+  int result = 0;
+  int f = -1;
+  f = bar ();
+  if (f < 0)
+    {
+      result = 1;
+      goto bail;
+    }
+  bar ();
+ bail:
+  bar2 (f);
+  return result;
+}
+
+/* { dg-final { scan-assembler-times "sub" 1 } } */
+/* { dg-final { scan-assembler-times "cmp" 0 } } */
+/* { dg-final { object-size text <= 30 } } */
+/* { dg-final { cleanup-saved-temps "pr43597" } } */