ChangeLog: Correct two dates.
diff mbox series

Message ID 1145232652.251039.1553687634758@poczta.nazwa.pl
State New
Headers show
Series
  • ChangeLog: Correct two dates.
Related show

Commit Message

Rafal Luzynski March 27, 2019, 11:53 a.m. UTC
OK for master?

This is trivial and very nit-picky but I'd better ask before just in
case the dates are exactly as the authors wanted them to be.

It's only in master and only after 2.29 release.  Also I'm not touching
one-off errors as long as they don't break the chronological order.
After all, these dates might have been correct in some time zones. :)

Regards,

Rafal


--------------------------------------------------------------------
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Date: Wed, 27 Mar 2019 12:46:24 +0100
Subject: [PATCH] ChangeLog: Correct two dates.

---
 ChangeLog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Carlos O'Donell March 27, 2019, 1:41 p.m. UTC | #1
On 3/27/19 7:53 AM, Rafal Luzynski wrote:
> OK for master?
> 
> This is trivial and very nit-picky but I'd better ask before just in
> case the dates are exactly as the authors wanted them to be.
> 
> It's only in master and only after 2.29 release.  Also I'm not touching
> one-off errors as long as they don't break the chronological order.
> After all, these dates might have been correct in some time zones. :)

No, these dates were obviously mistakes.

Please correct them. They should match checkin dates in git.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>  
  
> --------------------------------------------------------------------
> From: Rafal Luzynski <digitalfreak@lingonborough.com>
> Date: Wed, 27 Mar 2019 12:46:24 +0100
> Subject: [PATCH] ChangeLog: Correct two dates.
> 
> ---
>   ChangeLog | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index bd76c1e..b90af4b 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,4 +1,4 @@
> -2019-02-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> +2019-03-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>   
>   	* math/math.h (fpclassify, isfinite, isnormal, isnan): Use builtin for
>   	clang 2.8.
> @@ -184,7 +184,7 @@
>   	(HWCAP_S390_VXRS_EXT2, HWCAP_S390_VXRS_PDE, HWCAP_S390_SORT,
>   	HWCAP_S390_DFLT): Define.
>   
> -2019-03-05  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
> +2019-03-21  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
>   
>   	[BZ #24372]
>   	* iconv/iconvconfig.c (write_output): Add parentheses to get rid
>
Rafal Luzynski March 27, 2019, 1:52 p.m. UTC | #2
Carlos,

27.03.2019 14:41 Carlos O'Donell <codonell@redhat.com> wrote:
> On 3/27/19 7:53 AM, Rafal Luzynski wrote:
> > [...]
> > It's only in master and only after 2.29 release.  Also I'm not touching
> > one-off errors as long as they don't break the chronological order.
> > After all, these dates might have been correct in some time zones. :)
> 
> No, these dates were obviously mistakes.
> 
> Please correct them. They should match checkin dates in git.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>  

Thanks for your reply.  However, your answer is ambiguous, probably
because my questions were ambiguous.  After reading twice I must ask
if I understand you correctly.  Do you mean that those corrections
are OK but I should also correct more dates if I discover that the
dates do not match?

Does your answer mean this patch is OK to push but I should prepare
another similar patch and send it for a review?

Regards,

Rafal
Carlos O'Donell March 27, 2019, 2:32 p.m. UTC | #3
On 3/27/19 9:52 AM, Rafal Luzynski wrote:
> Carlos,
> 
> 27.03.2019 14:41 Carlos O'Donell <codonell@redhat.com> wrote:
>> On 3/27/19 7:53 AM, Rafal Luzynski wrote:
>>> [...]
>>> It's only in master and only after 2.29 release.  Also I'm not touching
>>> one-off errors as long as they don't break the chronological order.
>>> After all, these dates might have been correct in some time zones. :)
>>
>> No, these dates were obviously mistakes.
>>
>> Please correct them. They should match checkin dates in git.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> Thanks for your reply.  However, your answer is ambiguous, probably
> because my questions were ambiguous.  After reading twice I must ask
> if I understand you correctly.  Do you mean that those corrections
> are OK but I should also correct more dates if I discover that the
> dates do not match?

My 'Reviewed-by' indicates my belief that your patch is OK for master.

> Does your answer mean this patch is OK to push but I should prepare
> another similar patch and send it for a review?

Yes it is OK to push your current patch.

Yes it is OK to push *other* patches that correct the dates to match
the git commit dates.

In the future we'll generate the Changelog entry from the git commit
and then the dates will never be wrong.

Right Siddhesh?
Zack Weinberg March 27, 2019, 2:36 p.m. UTC | #4
On Wed, Mar 27, 2019 at 10:33 AM Carlos O'Donell <codonell@redhat.com> wrote:
> Yes it is OK to push *other* patches that correct the dates to match
> the git commit dates.

For the record, I would have assumed that correcting the date in a
ChangeLog entry to match the git commit date was like correcting a
typo in a comment: no approval required, just post the patch and then
go ahead and commit it.

zw
Carlos O'Donell March 27, 2019, 3:24 p.m. UTC | #5
On 3/27/19 10:36 AM, Zack Weinberg wrote:
> On Wed, Mar 27, 2019 at 10:33 AM Carlos O'Donell <codonell@redhat.com> wrote:
>> Yes it is OK to push *other* patches that correct the dates to match
>> the git commit dates.
> 
> For the record, I would have assumed that correcting the date in a
> ChangeLog entry to match the git commit date was like correcting a
> typo in a comment: no approval required, just post the patch and then
> go ahead and commit it.

I agree.

I've added it to Consensus.

https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
~~~
  * Anyone can commit a change to master fixing the date in a ChangeLog
entry to match the git commit date. There is no need to post the patch
for review, simply make the change and then push the commit. This is
only allowed for master where consensus is that dates should be
correct. There is still no clear consensus around what the ChangeLog
date should be for a cherry-picked change into a non-master branch.
~~~
Gabriel F. T. Gomes March 27, 2019, 3:52 p.m. UTC | #6
On Wed, Mar 27 2019, Rafal Luzynski wrote:
>  
> -2019-03-05  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
> +2019-03-21  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>

Sorry about that.  It was definitely a mistake from my part (I probably
copied the line from a previous ChangeLog entry with my name on it).

Thanks.
Siddhesh Poyarekar March 27, 2019, 4:14 p.m. UTC | #7
On 27/03/19 8:02 PM, Carlos O'Donell wrote:
> In the future we'll generate the Changelog entry from the git commit
> and then the dates will never be wrong.
> 
> Right Siddhesh?

That is correct, provided of course that the git commit log dates are
correct ;)

Siddhesh
Adhemerval Zanella March 27, 2019, 4:25 p.m. UTC | #8
On 27/03/2019 08:53, Rafal Luzynski wrote:
> OK for master?
> 
> This is trivial and very nit-picky but I'd better ask before just in
> case the dates are exactly as the authors wanted them to be.
> 
> It's only in master and only after 2.29 release.  Also I'm not touching
> one-off errors as long as they don't break the chronological order.
> After all, these dates might have been correct in some time zones. :)
> 
> Regards,
> 
> Rafal
> 
> 

Thanks for catching it.

> --------------------------------------------------------------------
> From: Rafal Luzynski <digitalfreak@lingonborough.com>
> Date: Wed, 27 Mar 2019 12:46:24 +0100
> Subject: [PATCH] ChangeLog: Correct two dates.
> 
> ---
>  ChangeLog | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index bd76c1e..b90af4b 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,4 +1,4 @@
> -2019-02-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> +2019-03-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>  
>  	* math/math.h (fpclassify, isfinite, isnormal, isnan): Use builtin for
>  	clang 2.8.
> @@ -184,7 +184,7 @@
>  	(HWCAP_S390_VXRS_EXT2, HWCAP_S390_VXRS_PDE, HWCAP_S390_SORT,
>  	HWCAP_S390_DFLT): Define.
>  
> -2019-03-05  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
> +2019-03-21  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
>  
>  	[BZ #24372]
>  	* iconv/iconvconfig.c (write_output): Add parentheses to get rid
>
Rafal Luzynski March 28, 2019, 12:01 a.m. UTC | #9
27.03.2019 15:32 Carlos O'Donell <codonell@redhat.com> wrote:
> On 3/27/19 9:52 AM, Rafal Luzynski wrote:
> [...]
> > Does your answer mean this patch is OK to push but I should prepare
> > another similar patch and send it for a review?
> 
> Yes it is OK to push your current patch.

Thank you, now I understand.  Pushed to master.

Regards,

Rafal
Rafal Luzynski March 28, 2019, 12:05 a.m. UTC | #10
27.03.2019 16:52 "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> wrote:
> [...]
> Sorry about that.  It was definitely a mistake from my part (I probably
> copied the line from a previous ChangeLog entry with my name on it).
> 
> Thanks.

I apologize those people who are explicitly mentioned in these patches.
It was not my intention to associate your names with omissions, it is
just obviously impossible to avoid.

Regards,

Rafal

Patch
diff mbox series

diff --git a/ChangeLog b/ChangeLog
index bd76c1e..b90af4b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@ 
-2019-02-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
+2019-03-26  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* math/math.h (fpclassify, isfinite, isnormal, isnan): Use builtin for
 	clang 2.8.
@@ -184,7 +184,7 @@ 
 	(HWCAP_S390_VXRS_EXT2, HWCAP_S390_VXRS_PDE, HWCAP_S390_SORT,
 	HWCAP_S390_DFLT): Define.
 
-2019-03-05  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
+2019-03-21  Gabriel F. T. Gomes  <gabriel@inconstante.eti.br>
 
 	[BZ #24372]
 	* iconv/iconvconfig.c (write_output): Add parentheses to get rid