Patchwork jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t

login
register
mail settings
Submitter Wang Sheng-Hui
Date July 25, 2011, 1:02 p.m.
Message ID <4E2D6961.9000909@gmail.com>
Download mbox | patch
Permalink /patch/106658/
State New
Headers show

Comments

Wang Sheng-Hui - July 25, 2011, 1:02 p.m.
The patch is against 3.0

In the definition of struct journal_head, the comment for
the field "unsigned b_cow_tid" says the field tracks the
last transaction id in which this buffer has been cowed.

In the header part of file journal-head.h, it defines
   typedef unsigned int  tid_t;
We should use type tid_t to define transaction id fields.

Change the field "b_cow_tid" of struct journal_head from
type unsigned to tid_t.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 include/linux/journal-head.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Amir Goldstein - July 25, 2011, 1:25 p.m.
On Mon, Jul 25, 2011 at 4:02 PM, Wang Sheng-Hui <shhuiw@gmail.com> wrote:
> The patch is against 3.0
>
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
>
> In the header part of file journal-head.h, it defines
>   typedef unsigned int  tid_t;
> We should use type tid_t to define transaction id fields.
>
> Change the field "b_cow_tid" of struct journal_head from
> type unsigned to tid_t.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

my bad.

Acked-by: Amir Goldstein <amir73il@users.sf.net>

> ---
>  include/linux/journal-head.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 44e95d0..423cb6d 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -45,7 +45,7 @@ struct journal_head {
>         * has been cowed
>         * [jbd_lock_bh_state()]
>         */
> -       unsigned b_cow_tid;
> +       tid_t b_cow_tid;
>
>        /*
>         * Copy of the buffer data frozen for writing to the log.
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig - July 25, 2011, 1:44 p.m.
On Mon, Jul 25, 2011 at 09:02:25PM +0800, Wang Sheng-Hui wrote:
> The patch is against 3.0
> 
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.

The correct fix is to simply remove the field, as it's entirely unused.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Amir Goldstein - July 25, 2011, 2:19 p.m.
On Mon, Jul 25, 2011 at 4:44 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Jul 25, 2011 at 09:02:25PM +0800, Wang Sheng-Hui wrote:
>> The patch is against 3.0
>>
>> In the definition of struct journal_head, the comment for
>> the field "unsigned b_cow_tid" says the field tracks the
>> last transaction id in which this buffer has been cowed.
>
> The correct fix is to simply remove the field, as it's entirely unused.
>

It's part of the ext4 snapshot patches, which are making their way into mainline
as slowly as one could expect them to.
This patch was merged for 2.6.39, so more users will be able to test
ext4 snapshots
independent module without having to patch their kernels, so that the
patches get proper
QA before they arrive to mainline.

Cheers,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara - July 25, 2011, 3:31 p.m.
On Mon 25-07-11 21:02:25, Wang Sheng-Hui wrote:
> The patch is against 3.0
> 
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
> 
> In the header part of file journal-head.h, it defines
>    typedef unsigned int  tid_t;
> We should use type tid_t to define transaction id fields.
> 
> Change the field "b_cow_tid" of struct journal_head from
> type unsigned to tid_t.
  Hmm, I didn't notice Ted merged this from ext4cow patch series. Looking
at struct journal_head, I'm thinking we might split jbd and jbd2 version of
this structure. jbd one could be 16 bytes shorter. Anyway, I've merged your
patch. Thanks.

								Honza
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  include/linux/journal-head.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 44e95d0..423cb6d 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -45,7 +45,7 @@ struct journal_head {
>  	 * has been cowed
>  	 * [jbd_lock_bh_state()]
>  	 */
> -	unsigned b_cow_tid;
> +	tid_t b_cow_tid;
>  
>  	/*
>  	 * Copy of the buffer data frozen for writing to the log.
> -- 
> 1.7.1
>

Patch

diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
index 44e95d0..423cb6d 100644
--- a/include/linux/journal-head.h
+++ b/include/linux/journal-head.h
@@ -45,7 +45,7 @@  struct journal_head {
 	 * has been cowed
 	 * [jbd_lock_bh_state()]
 	 */
-	unsigned b_cow_tid;
+	tid_t b_cow_tid;
 
 	/*
 	 * Copy of the buffer data frozen for writing to the log.