Patchwork [testsuite] Fix gcc.dg/vect/vect-70.c (was Re: vect-70.c fails on spu-elf)

login
register
mail settings
Submitter Ira Rosen
Date July 25, 2011, 11:41 a.m.
Message ID <OF4C1FD1A6.93B35DED-ONC22578D8.003C32E6-C22578D8.00403C1A@il.ibm.com>
Download mbox | patch
Permalink /patch/106638/
State New
Headers show

Comments

Ira Rosen - July 25, 2011, 11:41 a.m.
"Ulrich Weigand" <uweigand@de.ibm.com> wrote on 25/07/2011 12:19:54 PM:

> Ira Rosen wrote:
> > "Ulrich Weigand" <uweigand@de.ibm.com> wrote on 22/07/2011 05:05:57 PM:
> > > Any suggestions how to fix this?  Maybe decrease N again and instead
> > > prevent unrolling via command line switch?
> >
> > There is no flag for this unrolling, but we can run the test with -O1
> > instead of -O2 (and with N=12) by renaming vect-70.c to O1-vect-70.c
(see
> > the attached patch).
> >
> > > Maybe just decrease
> > > *some* dimensions of the tmp1 array?
> >
> > This can help too, if it is small enough:
>
> Either of the two patches you suggest fix the problem for me on spu-elf.

OK, so I am choosing the second patch.
Tested by Ulrich on spu-elf, and on x86_64-suse-linux.

OK for mainline? And 4.6?

Thanks,
Ira

testsuite/ChangeLog:

	* gcc.dg/vect/vect-70.c: Reduce the data size to fit
	SPU local store.
Mike Stump - July 25, 2011, 11:39 p.m.
On Jul 25, 2011, at 4:41 AM, Ira Rosen wrote:
> OK, so I am choosing the second patch.
> Tested by Ulrich on spu-elf, and on x86_64-suse-linux.
> 
> OK for mainline? And 4.6?

Ok.  Maintainers in particular areas should feel free to review/approve testsuite patches in their areas.  Since you're a vector maintainer, and this is a vector testcase, I think you're the natural person to approve it here.

> testsuite/ChangeLog:
> 
> 	* gcc.dg/vect/vect-70.c: Reduce the data size to fit
> 	SPU local store.

Patch

Index: testsuite/gcc.dg/vect/vect-70.c
===================================================================
--- testsuite/gcc.dg/vect/vect-70.c     (revision 176495)
+++ testsuite/gcc.dg/vect/vect-70.c     (working copy)
@@ -7,7 +7,7 @@ 

 struct s{
   int m;
-  int n[N][N][N];
+  int n[N/6][N/6][N];
 };

 struct test1{