Message ID | 20190326121642.23302-2-sr@denx.de |
---|---|
State | Superseded |
Delegated to: | Eugen Hristev |
Headers | show |
Series | [U-Boot,01/12,v2] arm: at91: Makefile: Compile lowlevel_init only when really necessary | expand |
Hello Stefan, Am 26.03.2019 um 13:16 schrieb Stefan Roese: > This patch adds a call to spl_early_init() to board_init_f() which is > needed when CONFIG_SPL_OF_CONTROL is configured. This is necessary for > the early SPL setup including the DTB setup for later usage. > > Please note that this call might also be needed for non SPL_OF_CONTROL > board, like the smartweb target. But smartweb fails to build with this > call because its binary grows too big. So I disabled it for these kind > of targets for now. > > Signed-off-by: Stefan Roese <sr@denx.de> > Cc: Heiko Schocher <hs@denx.de> > Cc: Andreas Bießmann <andreas@biessmann.org> > Cc: Eugen Hristev <eugen.hristev@microchip.com> > --- > v2: > - No change > > arch/arm/mach-at91/spl_at91.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) Reviewed-by: Heiko Schocher <hs@denx.de> Tested on the taurus board: Tested-by: Heiko Schocher <hs@denx.de> Yes ... smartweb board ... The problem is, I have there only 4k for SPL ... no chance for DM nor DTS ... bye, Heiko
diff --git a/arch/arm/mach-at91/spl_at91.c b/arch/arm/mach-at91/spl_at91.c index 23ebaa99b1..1065f090e0 100644 --- a/arch/arm/mach-at91/spl_at91.c +++ b/arch/arm/mach-at91/spl_at91.c @@ -75,6 +75,16 @@ void __weak spl_board_init(void) void board_init_f(ulong dummy) { +#if CONFIG_IS_ENABLED(OF_CONTROL) + int ret; + + ret = spl_early_init(); + if (ret) { + debug("spl_early_init() failed: %d\n", ret); + hang(); + } +#endif + lowlevel_clock_init(); #if !defined(CONFIG_WDT_AT91) at91_disable_wdt();
This patch adds a call to spl_early_init() to board_init_f() which is needed when CONFIG_SPL_OF_CONTROL is configured. This is necessary for the early SPL setup including the DTB setup for later usage. Please note that this call might also be needed for non SPL_OF_CONTROL board, like the smartweb target. But smartweb fails to build with this call because its binary grows too big. So I disabled it for these kind of targets for now. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Heiko Schocher <hs@denx.de> Cc: Andreas Bießmann <andreas@biessmann.org> Cc: Eugen Hristev <eugen.hristev@microchip.com> --- v2: - No change arch/arm/mach-at91/spl_at91.c | 10 ++++++++++ 1 file changed, 10 insertions(+)