From patchwork Sun Jul 24 17:38:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 106540 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EFA41B6F82 for ; Mon, 25 Jul 2011 03:38:48 +1000 (EST) Received: from localhost ([::1]:45429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ql2dZ-00089r-Ql for incoming@patchwork.ozlabs.org; Sun, 24 Jul 2011 13:38:45 -0400 Received: from eggs.gnu.org ([140.186.70.92]:42817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ql2dT-00088t-Qy for qemu-devel@nongnu.org; Sun, 24 Jul 2011 13:38:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ql2dS-0000j0-Sm for qemu-devel@nongnu.org; Sun, 24 Jul 2011 13:38:39 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:52880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ql2dS-0000im-Mh for qemu-devel@nongnu.org; Sun, 24 Jul 2011 13:38:38 -0400 Received: from smtp07.web.de ( [172.20.5.215]) by fmmailgate01.web.de (Postfix) with ESMTP id 8AC081944AC28; Sun, 24 Jul 2011 19:38:37 +0200 (CEST) Received: from [88.64.2.82] (helo=mchn199C.mchp.siemens.de) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1Ql2dR-0000lA-00; Sun, 24 Jul 2011 19:38:37 +0200 Message-ID: <4E2C589C.8040101@web.de> Date: Sun, 24 Jul 2011 19:38:36 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-devel , Markus Armbruster References: <4E2C4DE1.6010002@web.de> In-Reply-To: <4E2C4DE1.6010002@web.de> X-Enigmail-Version: 1.2 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+RivXECZ6B0QUfRr7NKtqrK4afvIVdT4jP9AIp s3Tvq7oFa3XuMk2pK9hvO4jOYbfyv7rrQ4nuM4jpcFG79bdwUl a75+FinuE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 217.72.192.221 Cc: Gleb Natapov Subject: [Qemu-devel] [PATCH v2] qdev: Reset hot-plugged devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka Device models rely on the core invoking their reset handlers after init. We do this in the cold-plug case, but so far we miss this step after hot-plug. Signed-off-by: Jan Kiszka --- Changes in v2: - move reset to qdev_init in case the device is created by the hot-plugged one (composed devices) hw/qdev.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index a0fcd06..b4ea8e1 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -289,6 +289,9 @@ int qdev_init(DeviceState *dev) dev->alias_required_for_version); } dev->state = DEV_STATE_INITIALIZED; + if (dev->hotplugged && dev->info->reset) { + dev->info->reset(dev); + } return 0; }