Patchwork [06/28] PPC: MPIC: Remove read functionality for WO registers

login
register
mail settings
Submitter Alexander Graf
Date July 23, 2011, 10:49 a.m.
Message ID <1311418212-13356-7-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/106431/
State New
Headers show

Comments

Alexander Graf - July 23, 2011, 10:49 a.m.
The IPI dispatch registers are write only according to every MPIC
spec I have found. So instead of pretending you could read back something
from them, better not handle them at all.

Reported-by: Elie Richa <richa@adacore.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/openpic.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

Patch

diff --git a/hw/openpic.c b/hw/openpic.c
index 1f7753d..3f50421 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -952,13 +952,6 @@  static uint32_t openpic_cpu_read_internal(void *opaque, target_phys_addr_t addr,
     case 0xB0: /* PEOI */
         retval = 0;
         break;
-#if MAX_IPI > 0
-    case 0x40: /* IDE */
-    case 0x50:
-        idx = (addr - 0x40) >> 4;
-        retval = read_IRQreg(opp, opp->irq_ipi0 + idx, IRQ_IDE);
-        break;
-#endif
     default:
         break;
     }