From patchwork Sat Jul 23 10:33:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 106427 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 56D12B6F00 for ; Sat, 23 Jul 2011 20:33:53 +1000 (EST) Received: from localhost ([::1]:42077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkZWm-00039X-TG for incoming@patchwork.ozlabs.org; Sat, 23 Jul 2011 06:33:48 -0400 Received: from eggs.gnu.org ([140.186.70.92]:48582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkZWh-00039H-1G for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:33:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkZWf-00031F-V6 for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:33:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53852 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkZWf-000317-Mm for qemu-devel@nongnu.org; Sat, 23 Jul 2011 06:33:41 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 8F008890B6; Sat, 23 Jul 2011 12:33:40 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) From: Alexander Graf In-Reply-To: <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> Date: Sat, 23 Jul 2011 12:33:39 +0200 Message-Id: References: <1311108115-27128-4-git-send-email-mdroth@linux.vnet.ibm.com> <1311193177-22282-1-git-send-email-mdroth@linux.vnet.ibm.com> <81810A74-E616-4199-BB69-E7DE4AAE9C0C@suse.de> To: Michael Roth X-Mailer: Apple Mail (2.1084) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 195.135.220.15 Cc: agl@linux.vnet.ibm.com, Jes Sorensen , "qemu-devel@nongnu.org Developers" , Luiz Capitulino , Blue Swirl , Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] guest agent: qemu-ga daemon X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 23.07.2011, at 12:07, Alexander Graf wrote: > > On 20.07.2011, at 22:19, Michael Roth wrote: > >> This is the actual guest daemon, it listens for requests over a >> virtio-serial/isa-serial/unix socket channel and routes them through >> to dispatch routines, and writes the results back to the channel in >> a manner similar to QMP. >> >> A shorthand invocation: >> >> qemu-ga -d >> >> Is equivalent to: >> >> qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 \ >> -f /var/run/qemu-ga.pid -d >> >> Signed-off-by: Michael Roth > > A rebase on top of current HEAD gave me the following on openSUSE 11.1 PPC: > > > agraf@lychee:/home/agraf/release/qemu> make > CC qemu-ga.o > qemu-ga.c:40: error: expected specifier-qualifier-list before ‘GSocket’ > qemu-ga.c: In function ‘ga_logging_enabled’: > qemu-ga.c:127: error: ‘GAState’ has no member named ‘logging_enabled’ > qemu-ga.c: In function ‘ga_disable_logging’: > qemu-ga.c:132: error: ‘GAState’ has no member named ‘logging_enabled’ > qemu-ga.c: In function ‘ga_enable_logging’: > qemu-ga.c:137: error: ‘GAState’ has no member named ‘logging_enabled’ > qemu-ga.c: In function ‘ga_log’: [...] > ... but it also breaks here: > > qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_freeze’: > qga/guest-agent-commands.c:443: error: ‘FIFREEZE’ undeclared (first use in this function) > qga/guest-agent-commands.c:443: error: (Each undeclared identifier is reported only once > qga/guest-agent-commands.c:443: error: for each function it appears in.) > qga/guest-agent-commands.c: In function ‘qmp_guest_fsfreeze_thaw’: > qga/guest-agent-commands.c:481: error: ‘FITHAW’ undeclared (first use in this function) > > > which I guess is fixed with Anthony's patch? Not sure. Either way, please make sure to add proper configure checks before relying on obscure functionality. JFYI: The following patch fixes it for me :). Why are we pulling in such a huge feature just before rc0 anyways? This should go in after the stable fork, so it gets some time to cook before people end up having to use it. Alex diff --git a/configure b/configure index 6911c3b..156ae3c 100755 --- a/configure +++ b/configure @@ -2555,7 +2555,6 @@ if test "$softmmu" = yes ; then tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools" if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) $tools" - tools="qemu-ga\$(EXESUF) $tools" if [ "$check_utests" = "yes" ]; then tools="check-qint check-qstring check-qdict check-qlist $tools" tools="check-qfloat check-qjson $tools"