diff mbox series

arm64: tegra: Disable CQE Support for SDMMC4 on Tegra186

Message ID 20190325112807.24474-1-thierry.reding@gmail.com
State Accepted
Headers show
Series arm64: tegra: Disable CQE Support for SDMMC4 on Tegra186 | expand

Commit Message

Thierry Reding March 25, 2019, 11:28 a.m. UTC 
From: Jonathan Hunter <jonathanh@nvidia.com>

Enabling CQE support on Tegra186 Jetson TX2 has introduced a regression
that is causing accesses to the file-system on the eMMC to fail. Errors
such as the following have been observed ...

 mmc2: running CQE recovery
 mmc2: mmc_select_hs400 failed, error -110
 print_req_error: I/O error, dev mmcblk2, sector 8 flags 80700
 mmc2: cqhci: CQE failed to exit halt state

For now disable CQE support for Tegra186 until this issue is resolved.

Fixes: dfd3cb6feb73 arm64: tegra: Add CQE Support for SDMMC4
Signed-off-by: Jonathan Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Hi ARM SoC maintainers,

Turned out there was a hardware bug that currently prevents CQE from
working on Tegra186. Patches for this are being worked on and are on
track to be merged for v5.2 but they are too involved to make it into
v5.1, so let's back out CQE support on Tegra186.

Can you please apply this for v5.1-rc3?

Thanks,
Thierry

 arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Arnd Bergmann March 25, 2019, 4:09 p.m. UTC | #1 
On Mon, Mar 25, 2019 at 12:28 PM Thierry Reding
<thierry.reding@gmail.com> wrote:
>
> From: Jonathan Hunter <jonathanh@nvidia.com>
>
> Enabling CQE support on Tegra186 Jetson TX2 has introduced a regression
> that is causing accesses to the file-system on the eMMC to fail. Errors
> such as the following have been observed ...
>
>  mmc2: running CQE recovery
>  mmc2: mmc_select_hs400 failed, error -110
>  print_req_error: I/O error, dev mmcblk2, sector 8 flags 80700
>  mmc2: cqhci: CQE failed to exit halt state
>
> For now disable CQE support for Tegra186 until this issue is resolved.
>
> Fixes: dfd3cb6feb73 arm64: tegra: Add CQE Support for SDMMC4
> Signed-off-by: Jonathan Hunter <jonathanh@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi ARM SoC maintainers,
>
> Turned out there was a hardware bug that currently prevents CQE from
> working on Tegra186. Patches for this are being worked on and are on
> track to be merged for v5.2 but they are too involved to make it into
> v5.1, so let's back out CQE support on Tegra186.
>
> Can you please apply this for v5.1-rc3?
>

Applied on arm/fixes

      Arnd
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
index bb2045be8814..97aeb946ed5e 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
@@ -321,7 +321,6 @@ 
 		nvidia,default-trim = <0x9>;
 		nvidia,dqs-trim = <63>;
 		mmc-hs400-1_8v;
-		supports-cqe;
 		status = "disabled";
 	};