Patchwork [build] : Enable default_gnu_indirect_function on x86_64-*-linux*

login
register
mail settings
Submitter Uros Bizjak
Date July 22, 2011, 3:27 p.m.
Message ID <CAFULd4YZsAQ6ckFjXtU5-yyv=3tYQwTJOPhU9zmJxFOrnotj8g@mail.gmail.com>
Download mbox | patch
Permalink /patch/106315/
State New
Headers show

Comments

Uros Bizjak - July 22, 2011, 3:27 p.m.
Hello!

Fixing ifunc test function in the testsuite uncovered a nasty screwup
in config.gcc that prohibited usage of GNU indirect functions on
x86_64-*-linux*. Fixed by mirroring i[34567]86-*-linux* setting.

2011-07-22  Uros Bizjak  <ubizjak@gmail.com>

	* config.gcc (i[34567]86-*-linux*): Set
	default_gnu_indirect_function to yes.

Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32}.
Committed to mainline, will commit to 4.6 after regression tests
finish there.

Uros.
Uros Bizjak - July 22, 2011, 3:30 p.m.
On Fri, Jul 22, 2011 at 5:27 PM, Uros Bizjak <ubizjak@gmail.com> wrote:

> Fixing ifunc test function in the testsuite uncovered a nasty screwup
> in config.gcc that prohibited usage of GNU indirect functions on
> x86_64-*-linux*. Fixed by mirroring i[34567]86-*-linux* setting.
>
> 2011-07-22  Uros Bizjak  <ubizjak@gmail.com>
>
>        * config.gcc (i[34567]86-*-linux*): Set
>        default_gnu_indirect_function to yes.

(x86_64-*-linux*) in fact. Fixed typo in ChangeLog.

Uros.
H.J. Lu - July 22, 2011, 3:38 p.m.
On Fri, Jul 22, 2011 at 8:30 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Fri, Jul 22, 2011 at 5:27 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
>> Fixing ifunc test function in the testsuite uncovered a nasty screwup
>> in config.gcc that prohibited usage of GNU indirect functions on
>> x86_64-*-linux*. Fixed by mirroring i[34567]86-*-linux* setting.
>>
>> 2011-07-22  Uros Bizjak  <ubizjak@gmail.com>
>>
>>        * config.gcc (i[34567]86-*-linux*): Set
>>        default_gnu_indirect_function to yes.
>
> (x86_64-*-linux*) in fact. Fixed typo in ChangeLog.
>

Can we also enable it for Linux/iX86?
Uros Bizjak - July 22, 2011, 3:42 p.m.
On Fri, Jul 22, 2011 at 5:38 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>>> Fixing ifunc test function in the testsuite uncovered a nasty screwup
>>> in config.gcc that prohibited usage of GNU indirect functions on
>>> x86_64-*-linux*. Fixed by mirroring i[34567]86-*-linux* setting.
>>>
>>> 2011-07-22  Uros Bizjak  <ubizjak@gmail.com>
>>>
>>>        * config.gcc (i[34567]86-*-linux*): Set
>>>        default_gnu_indirect_function to yes.
>>
>> (x86_64-*-linux*) in fact. Fixed typo in ChangeLog.
>>
>
> Can we also enable it for Linux/iX86?

It is already enabled for this target.

Uros.

Patch

Index: config.gcc
===================================================================
--- config.gcc	(revision 176624)
+++ config.gcc	(working copy)
@@ -1327,8 +1327,10 @@ 
 		 i386/x86-64.h i386/gnu-user64.h"
 	case ${target} in
 	x86_64-*-linux*)
-	  tm_file="${tm_file} linux.h i386/linux64.h"
-	  default_gnu_indirect_function=glibc-2011 ;;
+		tm_file="${tm_file} linux.h i386/linux64.h"
+		# Assume modern glibc
+		default_gnu_indirect_function=yes
+		;;
 	x86_64-*-kfreebsd*-gnu) tm_file="${tm_file} kfreebsd-gnu.h i386/kfreebsd-gnu64.h" ;;
 	x86_64-*-knetbsd*-gnu) tm_file="${tm_file} knetbsd-gnu.h" ;;
 	esac