From patchwork Sun Mar 24 10:14:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 1063052 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="YT18zQMb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44RtYs1053z9sSG for ; Sun, 24 Mar 2019 21:15:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728810AbfCXKPM (ORCPT ); Sun, 24 Mar 2019 06:15:12 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44416 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfCXKOq (ORCPT ); Sun, 24 Mar 2019 06:14:46 -0400 Received: by mail-wr1-f67.google.com with SMTP id y7so2744361wrn.11 for ; Sun, 24 Mar 2019 03:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wTzRy17GQ9eTfGlBmCL83qdRwlpf9GPWkB6XRQuibUQ=; b=YT18zQMbFWs3IO0/i4D6rp7ueZS0hEVJtUByzFCRJaIKiYEd1hI6zQhBJ3F2FpHMYd +AYxQq/ESoHVF4mCx93nHkPeyOpNuW5mghu2gmNWNk4xQ4lEj3DANNgdN9LOdc7c1qT5 skJD3vEkrm/Jtg0vFryXxcKzC4tE7e9qZ4JmxGO5a9jTF9Auh4xtALFhu5EfqZOw+xb9 AuyC5ZlXY2+iAa2P8UZ283vD2nwjNdDG5wJ7MUBqQFYFU8RqpRJGwo04BCj2NhPrLPm6 MMo7XvblQ5EwwE4x9qRf/uzXWHk20h6GxtPU69M79cTODHVUYaVupptFcuUCmctxXKnb GWZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wTzRy17GQ9eTfGlBmCL83qdRwlpf9GPWkB6XRQuibUQ=; b=YdekUqMZpLT3YKdxMntUVJLDnB3BBYiRhiKdSSfe8KG+UQNsCHdGgTrFjTT7L/Rb+C cCf2UIbp2Pe2ukAgIJhuLS91z1qELU33x+BHWMWKeqgXNHyKWPqmcamGkjPCbvSngpkZ u5cNm6AiDbCNb+5xRztdeHp5vFHaGP0HeGJvdyYtt5xwCh99u6W+XvgbkUSQIA7egwOU PW8RW9mLX03b1vN3N9kmNY3wWvdy76EvY3UkDdBDDq6ylmW5uqQIQqbNH7B3WGTBR3Hc HcQz9aYlUMF0fjGqJhvHIUDNj32D1LiVl21GINWwvjdM71Phl4YURPtslHl3K4hI6Km1 yYMQ== X-Gm-Message-State: APjAAAW0bmMNS3SnjkMOaCjY+7DHpwxzEFA09jCHrVqwsTYkJF/ywq7q JV0AuIM+ST1c2PMz5efKyRBfzAxjyVg= X-Google-Smtp-Source: APXvYqwQVU05lYTTIrxM2uPd/sXi6cxvV8X3VGudyHX5vV55Jf+cpC7ZtHf1ZPrSMOMYIKlQuZt7ZQ== X-Received: by 2002:adf:f30a:: with SMTP id i10mr12118895wro.111.1553422484639; Sun, 24 Mar 2019 03:14:44 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id a17sm20182466wmg.40.2019.03.24.03.14.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 03:14:44 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v3 05/15] bnxt: call devlink_port_type_eth_set() before port register Date: Sun, 24 Mar 2019 11:14:28 +0100 Message-Id: <20190324101438.6376-6-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us> References: <20190324101438.6376-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Call devlink_port_type_eth_set() before devlink_port_register(). Bnxt instances won't change type during lifetime. This avoids one extra userspace devlink notification. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index ab6fd05c462b..a266bff559dc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -229,6 +229,7 @@ int bnxt_dl_register(struct bnxt *bp) goto err_dl_unreg; } + devlink_port_type_eth_set(&bp->dl_port, bp->dev); devlink_port_attrs_set(&bp->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL, bp->pf.port_id, false, 0); rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id); @@ -236,7 +237,6 @@ int bnxt_dl_register(struct bnxt *bp) netdev_err(bp->dev, "devlink_port_register failed"); goto err_dl_param_unreg; } - devlink_port_type_eth_set(&bp->dl_port, bp->dev); rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, ARRAY_SIZE(bnxt_dl_port_params));