From patchwork Sun Mar 24 10:14:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 1063046 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="BYSrbnft"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44RtYf72wFz9sSG for ; Sun, 24 Mar 2019 21:15:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbfCXKOz (ORCPT ); Sun, 24 Mar 2019 06:14:55 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39281 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728733AbfCXKOw (ORCPT ); Sun, 24 Mar 2019 06:14:52 -0400 Received: by mail-wm1-f67.google.com with SMTP id t124so6065159wma.4 for ; Sun, 24 Mar 2019 03:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8E/rKiGf6yFnTmukOisCgun28JW5DC++XRKHwuO/RUI=; b=BYSrbnft5a531CuX8ftxQJuPMQ6sofGSfGi0C/9QPF//ycyfPypxiJIyqAP5zo3WSo zDMJJuNcOAn6xb6XTkUNioF6W7tUj+J6DQ3qro9inmzds6JwE7K8ZzYHiWhsPAsot8Ob ALTV3xAxtMeuxXTO/Pe/61DBsLwX0tTe9/znHIkWNjaZToVbl+0D7DT/1198M1kuS83r 1nGkpHX8WUUV0pnjJRVkpo3VS3nrcg6SNKVO6R15rMY/LXH/0nWzMQfo/8YaxUQIphl3 p2cdFA52vfqPW9cAHPwNcIa8bJSiLTdGJq9qYq9UTjIWJQcZdscao70BfVkOLzhPTdSU r/uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8E/rKiGf6yFnTmukOisCgun28JW5DC++XRKHwuO/RUI=; b=MsvaZdmvj+3oPLvDXs7pp5BwJXP+hd39mHYl90wxXCXk81T7QLn38UNp4qgu8v88ZL 99fHc34WJQz/pJ1S+mevtkJqle1r588JlXz6I5sJhrjEj4M+LY5qDp+KwevINWJbi2vT RJxrOSXca6DXq+zNG7vleLFF4FBXUTkE4Bs50coMZHKrHztFKD6qYqM36mpXbxZxHhZB Yxp4y6EXRQYbHD3E7lyxI5uTR9pKJjniJObsKVwHkPvS9vec3Dlsarg8gKGoEpdCheMf sB1Sl7WSEMymZXa3cUpAXbphhC/QRA7ig/5PBkLK3XWZgHR74/muIhrxxGKGsyJ4vocN KQAA== X-Gm-Message-State: APjAAAUxnuTP4vxIdMx9kJLZW09k0j9VPqjyXySxRDoNeyYv4Zig8P+6 R6VyZCKeK0FHMfyhygatw/SpII/wqOQ= X-Google-Smtp-Source: APXvYqzg371LyYZL1CNobT0uE9numxoe+fkuf0eu432v/5cpBV67fmE6ZOXOzJr4j3xSRuLOrbj8mQ== X-Received: by 2002:a1c:6309:: with SMTP id x9mr2336747wmb.101.1553422491015; Sun, 24 Mar 2019 03:14:51 -0700 (PDT) Received: from localhost (ip-94-113-125-71.net.upcbroadband.cz. [94.113.125.71]) by smtp.gmail.com with ESMTPSA id x192sm8336073wmf.48.2019.03.24.03.14.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 03:14:50 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v3 12/15] bnxt: set devlink port type after registration Date: Sun, 24 Mar 2019 11:14:35 +0100 Message-Id: <20190324101438.6376-13-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190324101438.6376-1-jiri@resnulli.us> References: <20190324101438.6376-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Move the type set of devlink port after it is registered. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index a266bff559dc..ab6fd05c462b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -229,7 +229,6 @@ int bnxt_dl_register(struct bnxt *bp) goto err_dl_unreg; } - devlink_port_type_eth_set(&bp->dl_port, bp->dev); devlink_port_attrs_set(&bp->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL, bp->pf.port_id, false, 0); rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id); @@ -237,6 +236,7 @@ int bnxt_dl_register(struct bnxt *bp) netdev_err(bp->dev, "devlink_port_register failed"); goto err_dl_param_unreg; } + devlink_port_type_eth_set(&bp->dl_port, bp->dev); rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, ARRAY_SIZE(bnxt_dl_port_params));