From patchwork Fri Jul 22 08:52:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 106240 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2CDE8B6F71 for ; Fri, 22 Jul 2011 18:51:15 +1000 (EST) Received: from localhost ([::1]:55872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkBRw-0006eS-Co for incoming@patchwork.ozlabs.org; Fri, 22 Jul 2011 04:51:12 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkBRq-0006eK-JL for qemu-devel@nongnu.org; Fri, 22 Jul 2011 04:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkBRp-0003A1-E5 for qemu-devel@nongnu.org; Fri, 22 Jul 2011 04:51:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkBRp-00039p-5R for qemu-devel@nongnu.org; Fri, 22 Jul 2011 04:51:05 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6M8p4Z1030411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Jul 2011 04:51:04 -0400 Received: from shalem.localdomain.com (vpn1-6-54.ams2.redhat.com [10.36.6.54]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6M8p1J9028993; Fri, 22 Jul 2011 04:51:02 -0400 From: Hans de Goede To: Gerd Hoffmann Date: Fri, 22 Jul 2011 10:52:37 +0200 Message-Id: <1311324757-4886-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v2) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Define a state callback and make that generate chardev open/close events when called by the spice-server. Note the code ignores these events for a spicevmc with a subtypem of vdagent, this subtype specific knowledge is undesirable, but unavoidable, see: http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html Changes in v2: -Only ignore the state callback for spicevmc chardevs with a subtype of vdagent, instead of only allowing them for a subtype of usbredir Signed-off-by: Hans de Goede --- spice-qemu-char.c | 42 +++++++++++++++++++++++++++++++++++++++++- 1 files changed, 41 insertions(+), 1 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index ce75e91..4f82231 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -89,11 +89,48 @@ static int vmc_read(SpiceCharDeviceInstance *sin, uint8_t *buf, int len) return bytes; } +static void vmc_state(SpiceCharDeviceInstance *sin, int connected) +{ + SpiceCharDriver *scd = container_of(sin, SpiceCharDriver, sin); + int event; + + /* + * spice-server calls the state callback for the agent channel when the + * spice client connects / disconnects. Given that not the client but + * the server is doing the parsing of the messages this is wrong as the + * server is still listening. Worse, this causes the parser in the server + * to go out of sync, so we ignore state calls for subtype vdagent + * spicevmc chardevs. For the full story see: + * http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html + */ + if (strcmp(subtype, "vdagent") == 0) { + return; + } + + if ((scd->chr->opened && connected) || + (!scd->chr->opened && !connected)) { + return; + } + + if (connected) { + scd->chr->opened = 1; + event = CHR_EVENT_OPENED; + } else { + scd->chr->opened = 0; + event = CHR_EVENT_CLOSED; + } + + if (scd->chr->chr_event) { + scd->chr->chr_event(scd->chr->handler_opaque, event); + } +} + static SpiceCharDeviceInterface vmc_interface = { .base.type = SPICE_INTERFACE_CHAR_DEVICE, .base.description = "spice virtual channel char device", .base.major_version = SPICE_INTERFACE_CHAR_DEVICE_MAJOR, .base.minor_version = SPICE_INTERFACE_CHAR_DEVICE_MINOR, + .state = vmc_state, .write = vmc_write, .read = vmc_read, }; @@ -222,7 +259,10 @@ CharDriverState *qemu_chr_open_spice(QemuOpts *opts) chr->chr_guest_close = spice_chr_guest_close; s->unblock_timer = qemu_new_timer_ms(vm_clock, spice_chr_unblock, s); - qemu_chr_generic_open(chr); + /* See comment in vmc_state() */ + if (strcmp(subtype, "vdagent") == 0) { + qemu_chr_generic_open(chr); + } return chr; }