Patchwork [1/3] ext4: remove unused argument in ext4_ext_next_leaf_block

login
register
mail settings
Submitter Robin Dong
Date July 22, 2011, 2:23 a.m.
Message ID <1311301421-10533-1-git-send-email-hao.bigrat@gmail.com>
Download mbox | patch
Permalink /patch/106206/
State Accepted
Headers show

Comments

Robin Dong - July 22, 2011, 2:23 a.m.
From: Robin Dong <sanbai@taobao.com>

The argument "inode" in function ext4_ext_next_allocated_block looks useless,
so clean it.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/extents.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Theodore Ts'o - July 24, 2011, 1:55 a.m.
On Fri, Jul 22, 2011 at 10:23:39AM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
> 
> The argument "inode" in function ext4_ext_next_allocated_block looks useless,
> so clean it.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>

Thanks, added to the ext4 tree.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index eb63c7b..3966839 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1447,8 +1447,7 @@  ext4_ext_next_allocated_block(struct ext4_ext_path *path)
  * ext4_ext_next_leaf_block:
  * returns first allocated block from next leaf or EXT_MAX_BLOCKS
  */
-static ext4_lblk_t ext4_ext_next_leaf_block(struct inode *inode,
-					struct ext4_ext_path *path)
+static ext4_lblk_t ext4_ext_next_leaf_block(struct ext4_ext_path *path)
 {
 	int depth;
 
@@ -1766,7 +1765,7 @@  repeat:
 
 	/* probably next leaf has space for us? */
 	fex = EXT_LAST_EXTENT(eh);
-	next = ext4_ext_next_leaf_block(inode, path);
+	next = ext4_ext_next_leaf_block(path);
 	if (le32_to_cpu(newext->ee_block) > le32_to_cpu(fex->ee_block)
 	    && next != EXT_MAX_BLOCKS) {
 		ext_debug("next leaf block - %d\n", next);