Patchwork [testsuite] : Fix detection of ifunc support

login
register
mail settings
Submitter Uros Bizjak
Date July 21, 2011, 9:56 p.m.
Message ID <CAFULd4YdTQKYg7SbOJ348kYs5Gw2By48DJZJfMwB1jFdHfciXw@mail.gmail.com>
Download mbox | patch
Permalink /patch/106177/
State New
Headers show

Comments

Uros Bizjak - July 21, 2011, 9:56 p.m.
Hello!

Revision 164725 [1] broke detection of ifunc support in the testsuite
[2] due to extra "#endif" without if in the test function. Attached
patch fixes this up.

2011-07-21  Uros Bizjak  <ubizjak@gmail.com>

	* lib/target-supports.exp (check_ifunc_available): Fix test function.

The patch is tested on x86_64-pc-linux-gnu, but my toolchain does not
support ifunc attribute. Can somebody please test it with ifunc
support?

OTOH, the patch is kind of obvious, so OK for mainline?

[1] http://gcc.gnu.org/viewcvs?view=revision&revision=164725
[2] http://gcc.gnu.org/viewcvs/trunk/gcc/testsuite/lib/target-supports.exp?r1=164725&r2=164724&pathrev=164725

Uros.

Patch

Index: lib/target-supports.exp
===================================================================
--- lib/target-supports.exp	(revision 176584)
+++ lib/target-supports.exp	(working copy)
@@ -381,10 +381,8 @@ 
 	set obj ifunc[pid].o
         verbose "check_ifunc_available  compiling testfile $src" 2
 	set f [open $src "w"]
-	puts $f "#endif"
 	puts $f "#ifdef __cplusplus\nextern \"C\"\n#endif"
-	puts $f "void g() {}"
-	puts $f "void f() __attribute__((ifunc(\"g\")));"
+	puts $f "void g() {} f() __attribute__((ifunc(\"g\")));"
 	close $f
 	set lines [${tool}_target_compile $src $obj object ""]
 	file delete $src