Patchwork lm32: softusb: claim to support full speed

login
register
mail settings
Submitter Michael Walle
Date July 21, 2011, 6:52 p.m.
Message ID <1311274344-8720-1-git-send-email-michael@walle.cc>
Download mbox | patch
Permalink /patch/106141/
State New
Headers show

Comments

Michael Walle - July 21, 2011, 6:52 p.m.
The QEMU keyboard and mouse reports themselves as full speed devices,
though they are actually low speed devices. Until this is fixed, claim that
we are supporting full speed devices.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 hw/milkymist-softusb.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Michael Walle - July 26, 2011, 10:01 p.m.
Hi Anthony,

could you please apply this patch to the 0.15 (and master) branch.


Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  hw/milkymist-softusb.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
>      usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
> 
>      /* our two ports */
> +    /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> +     * report themselves as full speed devices. */
>      usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>      usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> 
>      /* and finally create an usb keyboard */
>      s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");
Michael Walle - Aug. 1, 2011, 9:44 p.m.
Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  hw/milkymist-softusb.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
>      usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
> 
>      /* our two ports */
> +    /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> +     * report themselves as full speed devices. */
>      usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>      usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> -            USB_SPEED_MASK_LOW);
> +            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> 
>      /* and finally create an usb keyboard */
>      s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");

Ping. Without this patch the whole milkymist target is non-functional in the 
0.15 release.
Gerd Hoffmann - Aug. 3, 2011, 1:17 p.m.
On 07/21/11 20:52, Michael Walle wrote:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
>
> Signed-off-by: Michael Walle<michael@walle.cc>

For both master+stable:

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd
Edgar Iglesias - Aug. 3, 2011, 11:36 p.m.
On Wed, Aug 03, 2011 at 03:17:07PM +0200, Gerd Hoffmann wrote:
> On 07/21/11 20:52, Michael Walle wrote:
> >The QEMU keyboard and mouse reports themselves as full speed devices,
> >though they are actually low speed devices. Until this is fixed, claim that
> >we are supporting full speed devices.
> >
> >Signed-off-by: Michael Walle<michael@walle.cc>
> 
> For both master+stable:
> 
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>


Thanks, I've applied it to both master and stable-0.15.

Cheers

Patch

diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
index ce2bfc6..abf7b59 100644
--- a/hw/milkymist-softusb.c
+++ b/hw/milkymist-softusb.c
@@ -310,10 +310,12 @@  static int milkymist_softusb_init(SysBusDevice *dev)
     usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
 
     /* our two ports */
+    /* FIXME: claim to support full speed devices. qemu mouse and keyboard
+     * report themselves as full speed devices. */
     usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
-            USB_SPEED_MASK_LOW);
+            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
     usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
-            USB_SPEED_MASK_LOW);
+            USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
 
     /* and finally create an usb keyboard */
     s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");