Patchwork iMX28: Fix emi_ddr_open pinmux

login
register
mail settings
Submitter Marek Vasut
Date July 21, 2011, 4:08 p.m.
Message ID <1311264490-5485-1-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/106090/
State New
Headers show

Comments

Marek Vasut - July 21, 2011, 4:08 p.m.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 arch/arm/mach-mxs/include/mach/iomux-mx28.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Uwe Kleine-König - July 21, 2011, 7:05 p.m.
On Thu, Jul 21, 2011 at 06:08:10PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  arch/arm/mach-mxs/include/mach/iomux-mx28.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> index f50fefd..1a95ecd 100644
> --- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> +++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> @@ -203,7 +203,7 @@
>  #define MX28_PAD_EMI_WEN__EMI_WEN			MXS_IOMUX_PAD_NAKED(6, 21, PAD_MUXSEL_0)
>  #define MX28_PAD_EMI_CE0N__EMI_CE0N			MXS_IOMUX_PAD_NAKED(6, 22, PAD_MUXSEL_0)
>  #define MX28_PAD_EMI_CE1N__EMI_CE1N			MXS_IOMUX_PAD_NAKED(6, 23, PAD_MUXSEL_0)
> -#define MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 24, PAD_MUXSEL_0)
> +#define MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 26, PAD_MUXSEL_0)
In my version of the i.MX28 Reference Manual (Rev. 1, 2010) pin24 is
correct. So if you're still convinced that 26 is correct you should point
out in the commit log that the Reference Manual is wrong and why you're
convinced it really is.

Best regards
Uwe
Marek Vasut - July 21, 2011, 7:44 p.m.
On Thursday, July 21, 2011 09:05:36 PM Uwe Kleine-König wrote:
> On Thu, Jul 21, 2011 at 06:08:10PM +0200, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > 
> >  arch/arm/mach-mxs/include/mach/iomux-mx28.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > b/arch/arm/mach-mxs/include/mach/iomux-mx28.h index f50fefd..1a95ecd
> > 100644
> > --- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > +++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
> > @@ -203,7 +203,7 @@
> > 
> >  #define MX28_PAD_EMI_WEN__EMI_WEN			MXS_IOMUX_PAD_NAKED(6, 21,
> >  PAD_MUXSEL_0) #define
> >  MX28_PAD_EMI_CE0N__EMI_CE0N			MXS_IOMUX_PAD_NAKED(6, 22, 
PAD_MUXSEL_0)
> >  #define MX28_PAD_EMI_CE1N__EMI_CE1N			MXS_IOMUX_PAD_NAKED(6, 23,
> >  PAD_MUXSEL_0)
> > 
> > -#define MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 24,
> > PAD_MUXSEL_0) +#define
> > MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 26, 
PAD_MUXSEL_0)
> 
> In my version of the i.MX28 Reference Manual (Rev. 1, 2010) pin24 is
> correct. So if you're still convinced that 26 is correct you should point
> out in the commit log that the Reference Manual is wrong and why you're
> convinced it really is.

Scrap this, you're right.
> 
> Best regards
> Uwe

Patch

diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx28.h b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
index f50fefd..1a95ecd 100644
--- a/arch/arm/mach-mxs/include/mach/iomux-mx28.h
+++ b/arch/arm/mach-mxs/include/mach/iomux-mx28.h
@@ -203,7 +203,7 @@ 
 #define MX28_PAD_EMI_WEN__EMI_WEN			MXS_IOMUX_PAD_NAKED(6, 21, PAD_MUXSEL_0)
 #define MX28_PAD_EMI_CE0N__EMI_CE0N			MXS_IOMUX_PAD_NAKED(6, 22, PAD_MUXSEL_0)
 #define MX28_PAD_EMI_CE1N__EMI_CE1N			MXS_IOMUX_PAD_NAKED(6, 23, PAD_MUXSEL_0)
-#define MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 24, PAD_MUXSEL_0)
+#define MX28_PAD_EMI_CKE__EMI_CKE			MXS_IOMUX_PAD_NAKED(6, 26, PAD_MUXSEL_0)
 
 /* MUXSEL_1 */
 #define MX28_PAD_GPMI_D00__SSP1_D0			MXS_IOMUX_PAD_NAKED(0,  0, PAD_MUXSEL_1)