From patchwork Thu Jul 21 14:45:07 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongqiang Yang X-Patchwork-Id: 106079 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2571FB6F18 for ; Fri, 22 Jul 2011 00:49:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754Ab1GUOtX (ORCPT ); Thu, 21 Jul 2011 10:49:23 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:54208 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527Ab1GUOtX (ORCPT ); Thu, 21 Jul 2011 10:49:23 -0400 Received: by pvh21 with SMTP id 21so405199pvh.19 for ; Thu, 21 Jul 2011 07:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=vkKCWO82mIKm7KwSOc0mEIVkaWx43JiKS/2OyaxHrB0=; b=Rl5PxCmvhanwEu5KjypbYbaRprgewFnxTej9SvhRXMlR8iTyp0t5cHj/S9hCt85ms8 ugraaw0s0/MpYV6z+5dm/INy3WWoy3BZChjJkTuO3qZ5++q4paPAtUkLygnf4+PBOQbD pUuSADgnKfaF5YBzXEA0/i8TDMA70e+7iyNLg= Received: by 10.68.65.163 with SMTP id y3mr397170pbs.166.1311259762510; Thu, 21 Jul 2011 07:49:22 -0700 (PDT) Received: from localhost.localdomain ([159.226.43.42]) by mx.google.com with ESMTPS id x1sm937473pbb.2.2011.07.21.07.49.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jul 2011 07:49:21 -0700 (PDT) From: Yongqiang Yang To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, Yongqiang Yang Subject: [PATCH] ext4: let ext4_init_inode_table() handle errors right Date: Thu, 21 Jul 2011 22:45:07 +0800 Message-Id: <1311259507-11716-1-git-send-email-xiaoqiangnk@gmail.com> X-Mailer: git-send-email 1.7.5.1 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This patch lets ext4_init_inode_table() handle errors right. ext4_init_inode_table() should down_write() alloc_sem which has been up_write()ed and stop the started journal handle. Signed-off-by: Yongqiang Yang --- fs/ext4/ialloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 21bb2f6..9c63f27 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1287,7 +1287,7 @@ extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group, group, used_blks, ext4_itable_unused_count(sb, gdp)); ret = 1; - goto out; + goto err_out; } blk = ext4_inode_table(sb, gdp) + used_blks;