Patchwork ext4: let ext4_init_inode_table() handle errors right

login
register
mail settings
Submitter Yongqiang Yang
Date July 21, 2011, 2:45 p.m.
Message ID <1311259507-11716-1-git-send-email-xiaoqiangnk@gmail.com>
Download mbox | patch
Permalink /patch/106079/
State Accepted
Headers show

Comments

Yongqiang Yang - July 21, 2011, 2:45 p.m.
This patch lets ext4_init_inode_table() handle errors right.
ext4_init_inode_table() should down_write() alloc_sem which
has been up_write()ed and stop the started journal handle.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 fs/ext4/ialloc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Theodore Ts'o - Aug. 1, 2011, 10:33 a.m.
On Thu, Jul 21, 2011 at 10:45:07PM +0800, Yongqiang Yang wrote:
> This patch lets ext4_init_inode_table() handle errors right.
> ext4_init_inode_table() should down_write() alloc_sem which
> has been up_write()ed and stop the started journal handle.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>

Thanks, added to the ext4 patch tree.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 21bb2f6..9c63f27 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1287,7 +1287,7 @@  extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
 			   group, used_blks,
 			   ext4_itable_unused_count(sb, gdp));
 		ret = 1;
-		goto out;
+		goto err_out;
 	}
 
 	blk = ext4_inode_table(sb, gdp) + used_blks;