| Message ID | 20190321124857.28132-1-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | .travis.yml: reduce number of targets built while disabling things | expand |
Hi Alex, thanks also for the other patch series that I'm testing right now to speed up Travis :) Just a comment below: On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote: > This build keeps timing out on Travis and it's unlikely including the > additional guest front-ends will catch any failures in the fallback > code. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 3fb3dab46e..2e06aee9d0 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -107,7 +107,7 @@ matrix: > > > - env: > - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" > + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" > Is removing --disable-user intentional here? Thanks, Stefano
Stefano Garzarella <sgarzare@redhat.com> writes: > Hi Alex, > thanks also for the other patch series that I'm testing right now to speed > up Travis :) > > Just a comment below: > > On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote: >> This build keeps timing out on Travis and it's unlikely including the >> additional guest front-ends will catch any failures in the fallback >> code. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .travis.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 3fb3dab46e..2e06aee9d0 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -107,7 +107,7 @@ matrix: >> >> >> - env: >> - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" >> + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" >> > > Is removing --disable-user intentional here? Yes - --disable-user just removes all user mode targets from the default target list. However as we are now explicitly listing the softmmu targets it is redundant. > > Thanks, > Stefano -- Alex Bennée
On Thu, Mar 21, 2019 at 03:57:43PM +0000, Alex Bennée wrote: > > Stefano Garzarella <sgarzare@redhat.com> writes: > > > Hi Alex, > > thanks also for the other patch series that I'm testing right now to speed > > up Travis :) > > > > Just a comment below: > > > > On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote: > >> This build keeps timing out on Travis and it's unlikely including the > >> additional guest front-ends will catch any failures in the fallback > >> code. > >> > >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > >> --- > >> .travis.yml | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/.travis.yml b/.travis.yml > >> index 3fb3dab46e..2e06aee9d0 100644 > >> --- a/.travis.yml > >> +++ b/.travis.yml > >> @@ -107,7 +107,7 @@ matrix: > >> > >> > >> - env: > >> - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" > >> + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" > >> > > > > Is removing --disable-user intentional here? > > Yes - --disable-user just removes all user mode targets from the default > target list. However as we are now explicitly listing the softmmu > targets it is redundant. > Clear! Sorry for the stupid question! Acked-by: Stefano Garzarella <sgarzare@redhat.com> Thanks, Stefano
Stefano Garzarella <sgarzare@redhat.com> writes: > On Thu, Mar 21, 2019 at 03:57:43PM +0000, Alex Bennée wrote: >> >> Stefano Garzarella <sgarzare@redhat.com> writes: >> >> > Hi Alex, >> > thanks also for the other patch series that I'm testing right now to speed >> > up Travis :) >> > >> > Just a comment below: >> > >> > On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote: >> >> This build keeps timing out on Travis and it's unlikely including the >> >> additional guest front-ends will catch any failures in the fallback >> >> code. >> >> >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> >> --- >> >> .travis.yml | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/.travis.yml b/.travis.yml >> >> index 3fb3dab46e..2e06aee9d0 100644 >> >> --- a/.travis.yml >> >> +++ b/.travis.yml >> >> @@ -107,7 +107,7 @@ matrix: >> >> >> >> >> >> - env: >> >> - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" >> >> + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" >> >> >> > >> > Is removing --disable-user intentional here? >> >> Yes - --disable-user just removes all user mode targets from the default >> target list. However as we are now explicitly listing the softmmu >> targets it is redundant. >> > > Clear! Sorry for the stupid question! There are no stupid questions ;-) > > Acked-by: Stefano Garzarella <sgarzare@redhat.com> Thanks. > > Thanks, > Stefano -- Alex Bennée
On 03/21/2019 09:48 AM, Alex Bennée wrote: > This build keeps timing out on Travis and it's unlikely including the > additional guest front-ends will catch any failures in the fallback > code. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/.travis.yml b/.travis.yml > index 3fb3dab46e..2e06aee9d0 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -107,7 +107,7 @@ matrix: > > > - env: > - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" > + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" > > > # Module builds are mostly of interest to major distros
diff --git a/.travis.yml b/.travis.yml index 3fb3dab46e..2e06aee9d0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -107,7 +107,7 @@ matrix: - env: - - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication" + - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" # Module builds are mostly of interest to major distros
This build keeps timing out on Travis and it's unlikely including the additional guest front-ends will catch any failures in the fallback code. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)