[-next] ubifs: remove unused function __ubifs_shash_final
diff mbox series

Message ID 20190320140955.11576-1-yuehaibing@huawei.com
State Accepted
Delegated to: Richard Weinberger
Headers show
Series
  • [-next] ubifs: remove unused function __ubifs_shash_final
Related show

Commit Message

YueHaibing March 20, 2019, 2:09 p.m. UTC
From: YueHaibing <yuehaibing@huawei.com>

There is no callers in tree, and can be removed.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/ubifs/auth.c | 18 ------------------
 1 file changed, 18 deletions(-)

Comments

Mukesh Ojha March 20, 2019, 8:05 p.m. UTC | #1
On 3/20/2019 7:39 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> There is no callers in tree, and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   fs/ubifs/auth.c | 18 ------------------
>   1 file changed, 18 deletions(-)
>
> diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
> index 5bf5fd0..2a40ccce 100644
> --- a/fs/ubifs/auth.c
> +++ b/fs/ubifs/auth.c
> @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
>   }
>   
>   /**
> - * __ubifs_shash_final - finalize shash
> - * @c: UBIFS file-system description object
> - * @desc: the descriptor
> - * @out: the output hash
> - *
> - * Simple wrapper around crypto_shash_final(), safe to be called with
> - * disabled authentication.
> - */
> -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
> -			u8 *out)
> -{
> -	if (ubifs_authenticated(c))
> -		return crypto_shash_final(desc, out);
> -
> -	return 0;
> -}
> -
> -/**
>    * ubifs_bad_hash - Report hash mismatches
>    * @c: UBIFS file-system description object
>    * @node: the node



Looks fine to be removed.

Acked-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh
Richard Weinberger March 20, 2019, 8:18 p.m. UTC | #2
Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
> 
> On 3/20/2019 7:39 PM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > There is no callers in tree, and can be removed.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >   fs/ubifs/auth.c | 18 ------------------
> >   1 file changed, 18 deletions(-)
> >
> > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
> > index 5bf5fd0..2a40ccce 100644
> > --- a/fs/ubifs/auth.c
> > +++ b/fs/ubifs/auth.c
> > @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
> >   }
> >   
> >   /**
> > - * __ubifs_shash_final - finalize shash
> > - * @c: UBIFS file-system description object
> > - * @desc: the descriptor
> > - * @out: the output hash
> > - *
> > - * Simple wrapper around crypto_shash_final(), safe to be called with
> > - * disabled authentication.
> > - */
> > -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
> > -			u8 *out)
> > -{
> > -	if (ubifs_authenticated(c))
> > -		return crypto_shash_final(desc, out);
> > -
> > -	return 0;
> > -}
> > -
> > -/**
> >    * ubifs_bad_hash - Report hash mismatches
> >    * @c: UBIFS file-system description object
> >    * @node: the node
> 
> 
> 
> Looks fine to be removed.
> 
> Acked-by: Mukesh Ojha <mojha@codeaurora.org>

I guess you mean Reviewed-by?

Thanks,
//richard
Mukesh Ojha March 21, 2019, 7:54 a.m. UTC | #3
On 3/21/2019 1:48 AM, Richard Weinberger wrote:
> Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
>> On 3/20/2019 7:39 PM, Yue Haibing wrote:
>>> From: YueHaibing <yuehaibing@huawei.com>
>>>
>>> There is no callers in tree, and can be removed.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>>>    fs/ubifs/auth.c | 18 ------------------
>>>    1 file changed, 18 deletions(-)
>>>
>>> diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
>>> index 5bf5fd0..2a40ccce 100644
>>> --- a/fs/ubifs/auth.c
>>> +++ b/fs/ubifs/auth.c
>>> @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
>>>    }
>>>    
>>>    /**
>>> - * __ubifs_shash_final - finalize shash
>>> - * @c: UBIFS file-system description object
>>> - * @desc: the descriptor
>>> - * @out: the output hash
>>> - *
>>> - * Simple wrapper around crypto_shash_final(), safe to be called with
>>> - * disabled authentication.
>>> - */
>>> -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
>>> -			u8 *out)
>>> -{
>>> -	if (ubifs_authenticated(c))
>>> -		return crypto_shash_final(desc, out);
>>> -
>>> -	return 0;
>>> -}
>>> -
>>> -/**
>>>     * ubifs_bad_hash - Report hash mismatches
>>>     * @c: UBIFS file-system description object
>>>     * @node: the node
>>
>>
>> Looks fine to be removed.
>>
>> Acked-by: Mukesh Ojha <mojha@codeaurora.org>
> I guess you mean Reviewed-by?

As i am unsure about future scope of this func. i.e why Acked.


-Mukesh



>
> Thanks,
> //richard
>
>
>
Richard Weinberger March 21, 2019, 8:09 a.m. UTC | #4
Am Donnerstag, 21. März 2019, 08:54:55 CET schrieb Mukesh Ojha:
> >> Acked-by: Mukesh Ojha <mojha@codeaurora.org>
> > I guess you mean Reviewed-by?
> 
> As i am unsure about future scope of this func. i.e why Acked.

Acked-by is usually something I expect from the code author
or the person that owns the code.

Thanks,
//richard
Mukesh Ojha March 22, 2019, 6:59 a.m. UTC | #5
On 3/21/2019 1:39 PM, Richard Weinberger wrote:
> Am Donnerstag, 21. März 2019, 08:54:55 CET schrieb Mukesh Ojha:
>>>> Acked-by: Mukesh Ojha <mojha@codeaurora.org>
>>> I guess you mean Reviewed-by?
>> As i am unsure about future scope of this func. i.e why Acked.
> Acked-by is usually something I expect from the code author
> or the person that owns the code.

Take it as Reviewed-by then.

Thanks.
Mukesh

>
> Thanks,
> //richard
>
>

Patch
diff mbox series

diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
index 5bf5fd0..2a40ccce 100644
--- a/fs/ubifs/auth.c
+++ b/fs/ubifs/auth.c
@@ -147,24 +147,6 @@  struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
 }
 
 /**
- * __ubifs_shash_final - finalize shash
- * @c: UBIFS file-system description object
- * @desc: the descriptor
- * @out: the output hash
- *
- * Simple wrapper around crypto_shash_final(), safe to be called with
- * disabled authentication.
- */
-int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
-			u8 *out)
-{
-	if (ubifs_authenticated(c))
-		return crypto_shash_final(desc, out);
-
-	return 0;
-}
-
-/**
  * ubifs_bad_hash - Report hash mismatches
  * @c: UBIFS file-system description object
  * @node: the node