| Message ID | 20190319195419.12746-1-chunkeey@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v3,1/3] dt-bindings: net: dsa: qca8k: fix example | expand |
On 3/19/19 12:54 PM, Christian Lamparter wrote: > In the example, the phy at phy@0 is clashing with > the switch0@0 at the same address. Usually, the switches > are accessible through pseudo PHYs which in case of the > qca8k are located at 0x10 - 0x18. > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index bbcb255c3150..5eda99e6c86e 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -55,12 +55,12 @@ Example: reg = <4>; }; - switch0@0 { + switch@10 { compatible = "qca,qca8337"; #address-cells = <1>; #size-cells = <0>; - reg = <0>; + reg = <0x10>; ports { #address-cells = <1>;
In the example, the phy at phy@0 is clashing with the switch0@0 at the same address. Usually, the switches are accessible through pseudo PHYs which in case of the qca8k are located at 0x10 - 0x18. Signed-off-by: Christian Lamparter <chunkeey@gmail.com> --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)