diff mbox series

[net-next] datagram: Make __skb_datagram_iter static

Message ID 20190319145946.20504-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] datagram: Make __skb_datagram_iter static | expand

Commit Message

Yue Haibing March 19, 2019, 2:59 p.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

Fix sparse warning:

net/core/datagram.c:411:5: warning:
 symbol '__skb_datagram_iter' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/core/datagram.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Sagi Grimberg March 19, 2019, 4:43 p.m. UTC | #1 
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
David Miller March 19, 2019, 9:12 p.m. UTC | #2 
From: Yue Haibing <yuehaibing@huawei.com>
Date: Tue, 19 Mar 2019 22:59:46 +0800

> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> net/core/datagram.c:411:5: warning:
>  symbol '__skb_datagram_iter' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/net/core/datagram.c b/net/core/datagram.c
index b2651bb..ed8accb 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -408,10 +408,10 @@  int skb_kill_datagram(struct sock *sk, struct sk_buff *skb, unsigned int flags)
 }
 EXPORT_SYMBOL(skb_kill_datagram);
 
-int __skb_datagram_iter(const struct sk_buff *skb, int offset,
-			struct iov_iter *to, int len, bool fault_short,
-			size_t (*cb)(const void *, size_t, void *, struct iov_iter *),
-			void *data)
+static int __skb_datagram_iter(const struct sk_buff *skb, int offset,
+			       struct iov_iter *to, int len, bool fault_short,
+			       size_t (*cb)(const void *, size_t, void *,
+					    struct iov_iter *), void *data)
 {
 	int start = skb_headlen(skb);
 	int i, copy = start - offset, start_off = offset, n;