From patchwork Wed Jul 20 21:04:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 105836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A0403B6F70 for ; Thu, 21 Jul 2011 07:04:55 +1000 (EST) Received: (qmail 27204 invoked by alias); 20 Jul 2011 21:04:53 -0000 Received: (qmail 27196 invoked by uid 22791); 20 Jul 2011 21:04:53 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 21:04:10 +0000 Received: by wwj26 with SMTP id 26so612105wwj.8 for ; Wed, 20 Jul 2011 14:04:09 -0700 (PDT) Received: by 10.227.198.17 with SMTP id em17mr8367861wbb.4.1311195848898; Wed, 20 Jul 2011 14:04:08 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107]) by mx.google.com with ESMTPS id fe4sm499214wbb.28.2011.07.20.14.04.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Jul 2011 14:04:07 -0700 (PDT) From: Richard Sandiford To: Robert Millan Mail-Followup-To: Robert Millan , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] split mips/gnu-user.h from mips/linux.h References: <87y5zukv1l.fsf@firetop.home> Date: Wed, 20 Jul 2011 22:04:01 +0100 In-Reply-To: (Robert Millan's message of "Tue, 19 Jul 2011 22:48:01 +0200") Message-ID: <874o2gpsu6.fsf@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Robert Millan writes: > 2011/7/19 Richard Sandiford : >> needs to deal with linux64.h as well.  I also kept the copyright notice >> the same on linux.h (even though it's only a one-liner now). >> >> Applied with those changes, thanks. > > It's probably harmless, but with this change if --enable-targets=all > is used, then mips/gnu-user.h is included twice. The second one can > be removed. Oops, yes indeed. Applied as follows. Thanks, Richard 2011-07-20 Robert Millan * config.gcc (mips*-*-linux*): Remove redundant tm_file entry. Index: gcc/config.gcc =================================================================== --- gcc/config.gcc 2011-07-20 21:59:49.000000000 +0100 +++ gcc/config.gcc 2011-07-20 21:59:52.000000000 +0100 @@ -1845,7 +1845,7 @@ mips*-*-linux*) # Linux MIPS, either tm_file="dbxelf.h elfos.h gnu-user.h linux.h glibc-stdint.h ${tm_file} mips/gnu-user.h mips/linux.h" tmake_file="${tmake_file} mips/t-libgcc-mips16" if test x$enable_targets = xall; then - tm_file="${tm_file} mips/gnu-user.h mips/gnu-user64.h mips/linux64.h" + tm_file="${tm_file} mips/gnu-user64.h mips/linux64.h" tmake_file="${tmake_file} mips/t-linux64" tm_defines="${tm_defines} MIPS_ABI_DEFAULT=ABI_32" fi