| Message ID | 1552939602-22335-1-git-send-email-vgupta@synopsys.com |
|---|---|
| State | New |
| Headers | show |
| Series | auto filter aio tests of libc can't support aio | expand |
Hi Vineet, > uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter > out aio tests which it currently doesn't. > FWIW the tests sources themselves use a slightly different guard > HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H). > Anyhow that seems pointless as aio tests should not even build of libc > doesn't support the prerequsute header. > Signed-off-by: Vineet Gupta <vgupta@synopsys.com> > --- > testcases/kernel/io/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/testcases/kernel/io/Makefile b/testcases/kernel/io/Makefile > index 7db02882a530..3afae3888f63 100644 > --- a/testcases/kernel/io/Makefile > +++ b/testcases/kernel/io/Makefile > @@ -24,4 +24,8 @@ top_srcdir ?= ../../.. > include $(top_srcdir)/include/mk/env_pre.mk > +ifndef HAVE_LIBAIO_H > +FILTER_OUT_DIRS += aio > +endif This is IMHO wrong, as all files using libaio.h are guarded with TST_TEST_TCONF(). Kind regards, Petr
On 3/20/19 3:48 PM, Petr Vorel wrote: >> +ifndef HAVE_LIBAIO_H >> +FILTER_OUT_DIRS += aio >> +endif > This is IMHO wrong, as all files using libaio.h are guarded with > TST_TEST_TCONF(). You're right. It seems this ltp tree of mine had stray aio1 and aio2 dir in the io/aio which was actually tripping the build. With a pristine tree that is indeed not needed. Thx, -Vineet
diff --git a/testcases/kernel/io/Makefile b/testcases/kernel/io/Makefile index 7db02882a530..3afae3888f63 100644 --- a/testcases/kernel/io/Makefile +++ b/testcases/kernel/io/Makefile @@ -24,4 +24,8 @@ top_srcdir ?= ../../.. include $(top_srcdir)/include/mk/env_pre.mk +ifndef HAVE_LIBAIO_H +FILTER_OUT_DIRS += aio +endif + include $(top_srcdir)/include/mk/generic_trunk_target.mk
uClibc-ng lacks libaio.h and thus LTP UCLIBC=1 builds need to filter out aio tests which it currently doesn't. FWIW the tests sources themselves use a slightly different guard HAVE_LIBAIO (while autotool generate HAVE_LIBAIO_H). Anyhow that seems pointless as aio tests should not even build of libc doesn't support the prerequsute header. Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- testcases/kernel/io/Makefile | 4 ++++ 1 file changed, 4 insertions(+)