| Message ID | 20190318183312.4684-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | vl: Fix error location of positional arguments | expand |
On Mon, Mar 18, 2019 at 07:33:12PM +0100, Markus Armbruster wrote: > We blame badness in positional arguments on the last option argument: > > $ qemu-system-x86_64 -vnc :1 bad.img > qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory > > I believe we've done this ever since we reported locations. Fix it to > > qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or directory > > Reported-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
On Mon, Mar 18, 2019 at 07:33:12PM +0100, Markus Armbruster wrote: > We blame badness in positional arguments on the last option argument: > > $ qemu-system-x86_64 -vnc :1 bad.img > qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory > > I believe we've done this ever since we reported locations. Fix it to > > qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or directory > > Reported-by: Daniel P. Berrangé <berrange@redhat.com> > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
diff --git a/vl.c b/vl.c index c1d5484e12..9b215341a3 100644 --- a/vl.c +++ b/vl.c @@ -3119,6 +3119,7 @@ int main(int argc, char **argv, char **envp) if (optind >= argc) break; if (argv[optind][0] != '-') { + loc_set_cmdline(argv, optind, 1); drive_add(IF_DEFAULT, 0, argv[optind++], HD_OPTS); } else { const QEMUOption *popt;
We blame badness in positional arguments on the last option argument: $ qemu-system-x86_64 -vnc :1 bad.img qemu-system-x86_64: -vnc :1: Could not open 'foo': No such file or directory I believe we've done this ever since we reported locations. Fix it to qemu-system-x86_64: bad.img: Could not open 'bad.img': No such file or directory Reported-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> --- vl.c | 1 + 1 file changed, 1 insertion(+)