| Message ID | 20190318100521.29109-1-maxime.ripard@bootlin.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: cpu: Fix JSON schema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
+arm-soc On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for > Milbeaut") added support for a new cpu enable-method, but did so using > tabulations to ident. This is however invalid in the syntax, and resulted > in a failure when trying to use that schemas for validation. > > Use spaces instead of tabs to indent to fix this. > > Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> This should be applied to arm-soc tree having the commit. Rob
Hi Sugaya, Arnd, Olof, On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: > +arm-soc > > On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for > > Milbeaut") added support for a new cpu enable-method, but did so using > > tabulations to ident. This is however invalid in the syntax, and resulted > > in a failure when trying to use that schemas for validation. > > > > Use spaces instead of tabs to indent to fix this. > > > > Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > --- > > Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Rob Herring <robh@kernel.org> > > This should be applied to arm-soc tree having the commit. Could you pick up that patch? Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi Maxime, Thanks for pointing my bug. On 2019/04/01 18:10, Maxime Ripard wrote: > Hi Sugaya, Arnd, Olof, > > On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: >> +arm-soc >> >> On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: >>> >>> Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for >>> Milbeaut") added support for a new cpu enable-method, but did so using >>> tabulations to ident. This is however invalid in the syntax, and resulted >>> in a failure when trying to use that schemas for validation. >>> >>> Use spaces instead of tabs to indent to fix this. >>> >>> Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") >>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >>> --- >>> Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> >> This should be applied to arm-soc tree having the commit. > > Could you pick up that patch? > I got it. My mission is to resubmit your fix-patch added my singned-off tag and Rob's reviewed tag...right? Thanks, Sugaya Taichi > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
Hi, On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: > On 2019/04/01 18:10, Maxime Ripard wrote: > > Hi Sugaya, Arnd, Olof, > > > > On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: > > > +arm-soc > > > > > > On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for > > > > Milbeaut") added support for a new cpu enable-method, but did so using > > > > tabulations to ident. This is however invalid in the syntax, and resulted > > > > in a failure when trying to use that schemas for validation. > > > > > > > > Use spaces instead of tabs to indent to fix this. > > > > > > > > Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > > > --- > > > > Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > > > This should be applied to arm-soc tree having the commit. > > > > Could you pick up that patch? > > I got it. > My mission is to resubmit your fix-patch added my singned-off tag and > Rob's reviewed tag...right? If you are part of arm-soc and send your pull requests to Arnd and Olof, simply pick it up in the same branch than the initial patch was in. And when you apply that patch, you indeed need to add your Signed-off-by (note that most commands to commit have an option to do that automatically: -s and that includes git am) and the Rob's reviewed-by. Then, send a new pull request to arm-soc. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hi, On 2019/04/01 20:35, Maxime Ripard wrote: > Hi, > > On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: >> On 2019/04/01 18:10, Maxime Ripard wrote: >>> Hi Sugaya, Arnd, Olof, >>> >>> On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: >>>> +arm-soc >>>> >>>> On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: >>>>> >>>>> Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for >>>>> Milbeaut") added support for a new cpu enable-method, but did so using >>>>> tabulations to ident. This is however invalid in the syntax, and resulted >>>>> in a failure when trying to use that schemas for validation. >>>>> >>>>> Use spaces instead of tabs to indent to fix this. >>>>> >>>>> Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") >>>>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >>>>> --- >>>>> Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> Reviewed-by: Rob Herring <robh@kernel.org> >>>> >>>> This should be applied to arm-soc tree having the commit. >>> >>> Could you pick up that patch? >> >> I got it. >> My mission is to resubmit your fix-patch added my singned-off tag and >> Rob's reviewed tag...right? > > If you are part of arm-soc and send your pull requests to Arnd and > Olof, simply pick it up in the same branch than the initial patch was > in. And when you apply that patch, you indeed need to add your > Signed-off-by (note that most commands to commit have an option to do > that automatically: -s and that includes git am) and the Rob's > reviewed-by. > > Then, send a new pull request to arm-soc. > Okay, thanks for your suggestion. I try to make pull request! Thanks, Sugaya Taichi > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
Hi, On 2019/04/01 22:02, Sugaya, Taichi wrote: > Hi, > > On 2019/04/01 20:35, Maxime Ripard wrote: >> Hi, >> >> On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: >>> On 2019/04/01 18:10, Maxime Ripard wrote: >>>> Hi Sugaya, Arnd, Olof, >>>> >>>> On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: >>>>> +arm-soc >>>>> >>>>> On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: >>>>>> >>>>>> Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for >>>>>> Milbeaut") added support for a new cpu enable-method, but did so using >>>>>> tabulations to ident. This is however invalid in the syntax, and resulted >>>>>> in a failure when trying to use that schemas for validation. >>>>>> >>>>>> Use spaces instead of tabs to indent to fix this. >>>>>> >>>>>> Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") >>>>>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >>>>>> --- >>>>>> Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> Reviewed-by: Rob Herring <robh@kernel.org> >>>>> >>>>> This should be applied to arm-soc tree having the commit. >>>> >>>> Could you pick up that patch? >>> >>> I got it. >>> My mission is to resubmit your fix-patch added my singned-off tag and >>> Rob's reviewed tag...right? >> >> If you are part of arm-soc and send your pull requests to Arnd and >> Olof, simply pick it up in the same branch than the initial patch was >> in. And when you apply that patch, you indeed need to add your >> Signed-off-by (note that most commands to commit have an option to do >> that automatically: -s and that includes git am) and the Rob's >> reviewed-by. >> >> Then, send a new pull request to arm-soc. >> > > Okay, thanks for your suggestion. > I try to make pull request! > Sorry I realized that I couldn't make a private repository, so I'll send my Ack instead. Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com> > Thanks, > Sugaya Taichi > >> Maxime >> >> -- >> Maxime Ripard, Bootlin >> Embedded Linux and Kernel engineering >> https://bootlin.com >>
On 2019/04/02 20:42, Sugaya, Taichi wrote: > Hi, > > On 2019/04/01 22:02, Sugaya, Taichi wrote: >> Hi, >> >> On 2019/04/01 20:35, Maxime Ripard wrote: >>> Hi, >>> >>> On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: >>>> On 2019/04/01 18:10, Maxime Ripard wrote: >>>>> Hi Sugaya, Arnd, Olof, >>>>> >>>>> On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: >>>>>> +arm-soc >>>>>> >>>>>> On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: >>>>>>> >>>>>>> Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for >>>>>>> Milbeaut") added support for a new cpu enable-method, but did so using >>>>>>> tabulations to ident. This is however invalid in the syntax, and resulted >>>>>>> in a failure when trying to use that schemas for validation. >>>>>>> >>>>>>> Use spaces instead of tabs to indent to fix this. >>>>>>> >>>>>>> Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") >>>>>>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> Reviewed-by: Rob Herring <robh@kernel.org> >>>>>> >>>>>> This should be applied to arm-soc tree having the commit. >>>>> >>>>> Could you pick up that patch? >>>> >>>> I got it. >>>> My mission is to resubmit your fix-patch added my singned-off tag and >>>> Rob's reviewed tag...right? >>> >>> If you are part of arm-soc and send your pull requests to Arnd and >>> Olof, simply pick it up in the same branch than the initial patch was >>> in. And when you apply that patch, you indeed need to add your >>> Signed-off-by (note that most commands to commit have an option to do >>> that automatically: -s and that includes git am) and the Rob's >>> reviewed-by. >>> >>> Then, send a new pull request to arm-soc. >>> >> >> Okay, thanks for your suggestion. >> I try to make pull request! >> > > Sorry I realized that I couldn't make a private repository, so I'll send my Ack instead. One correction: "a public repository" > > Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com> > >> Thanks, >> Sugaya Taichi >> >>> Maxime >>> >>> -- >>> Maxime Ripard, Bootlin >>> Embedded Linux and Kernel engineering >>> https://bootlin.com >>>
On Tue, Apr 02, 2019 at 08:42:02PM +0900, Sugaya, Taichi wrote: > Hi, > > On 2019/04/01 22:02, Sugaya, Taichi wrote: > > Hi, > > > > On 2019/04/01 20:35, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: > > > > On 2019/04/01 18:10, Maxime Ripard wrote: > > > > > Hi Sugaya, Arnd, Olof, > > > > > > > > > > On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: > > > > > > +arm-soc > > > > > > > > > > > > On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > > > > > > > > > Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for > > > > > > > Milbeaut") added support for a new cpu enable-method, but did so using > > > > > > > tabulations to ident. This is however invalid in the syntax, and resulted > > > > > > > in a failure when trying to use that schemas for validation. > > > > > > > > > > > > > > Use spaces instead of tabs to indent to fix this. > > > > > > > > > > > > > > Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") > > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > > > > > > --- > > > > > > > Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > > > > > > > > > This should be applied to arm-soc tree having the commit. > > > > > > > > > > Could you pick up that patch? > > > > > > > > I got it. > > > > My mission is to resubmit your fix-patch added my singned-off tag and > > > > Rob's reviewed tag...right? > > > > > > If you are part of arm-soc and send your pull requests to Arnd and > > > Olof, simply pick it up in the same branch than the initial patch was > > > in. And when you apply that patch, you indeed need to add your > > > Signed-off-by (note that most commands to commit have an option to do > > > that automatically: -s and that includes git am) and the Rob's > > > reviewed-by. > > > > > > Then, send a new pull request to arm-soc. > > > > > > > Okay, thanks for your suggestion. > > I try to make pull request! > > > > Sorry I realized that I couldn't make a private repository, so I'll send my Ack instead. > > Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com> Applied to arm/fixes now. Thanks! -Olof
On 2019/04/08 7:13, Olof Johansson wrote: > On Tue, Apr 02, 2019 at 08:42:02PM +0900, Sugaya, Taichi wrote: >> Hi, >> >> On 2019/04/01 22:02, Sugaya, Taichi wrote: >>> Hi, >>> >>> On 2019/04/01 20:35, Maxime Ripard wrote: >>>> Hi, >>>> >>>> On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote: >>>>> On 2019/04/01 18:10, Maxime Ripard wrote: >>>>>> Hi Sugaya, Arnd, Olof, >>>>>> >>>>>> On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote: >>>>>>> +arm-soc >>>>>>> >>>>>>> On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: >>>>>>>> >>>>>>>> Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for >>>>>>>> Milbeaut") added support for a new cpu enable-method, but did so using >>>>>>>> tabulations to ident. This is however invalid in the syntax, and resulted >>>>>>>> in a failure when trying to use that schemas for validation. >>>>>>>> >>>>>>>> Use spaces instead of tabs to indent to fix this. >>>>>>>> >>>>>>>> Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") >>>>>>>> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> Reviewed-by: Rob Herring <robh@kernel.org> >>>>>>> >>>>>>> This should be applied to arm-soc tree having the commit. >>>>>> >>>>>> Could you pick up that patch? >>>>> >>>>> I got it. >>>>> My mission is to resubmit your fix-patch added my singned-off tag and >>>>> Rob's reviewed tag...right? >>>> >>>> If you are part of arm-soc and send your pull requests to Arnd and >>>> Olof, simply pick it up in the same branch than the initial patch was >>>> in. And when you apply that patch, you indeed need to add your >>>> Signed-off-by (note that most commands to commit have an option to do >>>> that automatically: -s and that includes git am) and the Rob's >>>> reviewed-by. >>>> >>>> Then, send a new pull request to arm-soc. >>>> >>> >>> Okay, thanks for your suggestion. >>> I try to make pull request! >>> >> >> Sorry I realized that I couldn't make a private repository, so I'll send my Ack instead. >> >> Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com> > > Applied to arm/fixes now. Thanks! > > > -Olof > Thank you for appling!
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml index 365dcf384d73..82dd7582e945 100644 --- a/Documentation/devicetree/bindings/arm/cpus.yaml +++ b/Documentation/devicetree/bindings/arm/cpus.yaml @@ -228,7 +228,7 @@ patternProperties: - renesas,r9a06g032-smp - rockchip,rk3036-smp - rockchip,rk3066-smp - - socionext,milbeaut-m10v-smp + - socionext,milbeaut-m10v-smp - ste,dbx500-smp cpu-release-addr:
Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") added support for a new cpu enable-method, but did so using tabulations to ident. This is however invalid in the syntax, and resulted in a failure when trying to use that schemas for validation. Use spaces instead of tabs to indent to fix this. Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut") Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- Documentation/devicetree/bindings/arm/cpus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)