| Message ID | 20190317230909.7373-1-colin.king@canonical.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | hostfs: fix mismatch between link_file definition and declaration | expand |
Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > The function link_file declaration in the header file has the order > of the two arguments (from, to) swapped when compared to the definition > arguments of (to, from). Fix this by swapping them around to match > the definition. > > This error predates the git history, so no idea when this error > was introduced. commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd Author: jdike <jdike> Date: Sat Dec 9 22:52:44 2000 +0000 hostfs now mostly works. Almost all of the common operations are now implemented, the main exceptions being mknod and executing files from a hostfs filesystem. Enough archaeology for today. :-) Thanks, //richard
On 17/03/2019 23:49, Richard Weinberger wrote: > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: >> From: Colin Ian King <colin.king@canonical.com> >> >> The function link_file declaration in the header file has the order >> of the two arguments (from, to) swapped when compared to the definition >> arguments of (to, from). Fix this by swapping them around to match >> the definition. >> >> This error predates the git history, so no idea when this error >> was introduced. > > commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd > Author: jdike <jdike> > Date: Sat Dec 9 22:52:44 2000 +0000 > > hostfs now mostly works. Almost all of the common operations are now > implemented, the main exceptions being mknod and executing files from > a hostfs filesystem. > > Enough archaeology for today. :-) Nice. How do you find these ancient git commits? > > Thanks, > //richard > >
Am Montag, 18. März 2019, 09:41:28 CET schrieb Colin Ian King: > On 17/03/2019 23:49, Richard Weinberger wrote: > > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King: > >> From: Colin Ian King <colin.king@canonical.com> > >> > >> The function link_file declaration in the header file has the order > >> of the two arguments (from, to) swapped when compared to the definition > >> arguments of (to, from). Fix this by swapping them around to match > >> the definition. > >> > >> This error predates the git history, so no idea when this error > >> was introduced. > > > > commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd > > Author: jdike <jdike> > > Date: Sat Dec 9 22:52:44 2000 +0000 > > > > hostfs now mostly works. Almost all of the common operations are now > > implemented, the main exceptions being mknod and executing files from > > a hostfs filesystem. > > > > Enough archaeology for today. :-) > > Nice. How do you find these ancient git commits? This commit is from the old UML cvs tree. I did a import to git some time ago and pushed it to: https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml-history.git/ For classic pre-git stuff, check: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/ Thanks, //richard
diff --git a/fs/hostfs/hostfs.h b/fs/hostfs/hostfs.h index 33b8423ef0c9..f4295aa19350 100644 --- a/fs/hostfs/hostfs.h +++ b/fs/hostfs/hostfs.h @@ -87,7 +87,7 @@ extern int do_mkdir(const char *file, int mode); extern int hostfs_do_rmdir(const char *file); extern int do_mknod(const char *file, int mode, unsigned int major, unsigned int minor); -extern int link_file(const char *from, const char *to); +extern int link_file(const char *to, const char *from); extern int hostfs_do_readlink(char *file, char *buf, int size); extern int rename_file(char *from, char *to); extern int rename2_file(char *from, char *to, unsigned int flags);