| Message ID | 20190317180742.17784-1-michael@walle.cc |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | [U-Boot] arm: kirkwood: lsxl: disable dcache | expand |
On Mon, Mar 18, 2019 at 7:08 AM Michael Walle <michael@walle.cc> wrote: > > Both the network as well as the USB driver are not working with the > data cache enabled. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > include/configs/lsxl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h > index 9d4be18413..728263910e 100644 > --- a/include/configs/lsxl.h > +++ b/include/configs/lsxl.h > @@ -32,6 +32,7 @@ > #define CONFIG_SHOW_BOOT_PROGRESS > > #define CONFIG_KIRKWOOD_GPIO > +#define CONFIG_SYS_DCACHE_OFF > Reviewed-by: Chris Packham <judge.packham@gmail.com> Having said that I'm wondering if this should be in arch/arm/mach-kirkwood/include/mach/config.h or automatically selected via Kconfig. As far as I can tell prior to commit 93b283d49f93 ("ARM: CPU: arm926ejs: Consolidate cache routines to common file") the kirkwood boards didn't have and dcache support. It might be possible to update the various drivers to use the proper DMA apis but for 2019.03 I think it might be safer just to run with CONFIG_SYS_DCACHE_OFF. > /* > * Commands configuration > -- > 2.11.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
diff --git a/include/configs/lsxl.h b/include/configs/lsxl.h index 9d4be18413..728263910e 100644 --- a/include/configs/lsxl.h +++ b/include/configs/lsxl.h @@ -32,6 +32,7 @@ #define CONFIG_SHOW_BOOT_PROGRESS #define CONFIG_KIRKWOOD_GPIO +#define CONFIG_SYS_DCACHE_OFF /* * Commands configuration
Both the network as well as the USB driver are not working with the data cache enabled. Signed-off-by: Michael Walle <michael@walle.cc> --- include/configs/lsxl.h | 1 + 1 file changed, 1 insertion(+)