diff mbox series

[U-Boot,02/18] mtd: nand: import nand_hw_control_init()

Message ID 1552659287-11246-3-git-send-email-philippe.reynes@softathome.com
State Accepted
Delegated to: Tom Rini
Headers show
Series Initial support of driver brcmnand (from kernel 4.18) | expand

Commit Message

Philippe REYNES March 15, 2019, 2:14 p.m. UTC 
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>

Linux commit d45bc58dd3b ("mtd: nand: import nand_hw_control_init()")

The code to initialize a struct nand_hw_control is duplicated across
several drivers. Factorize it using an inline function.

Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
[Philippe Reynes: adapt code to u-boot and only keep new function]

Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
 include/linux/mtd/rawnand.h | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Tom Rini April 24, 2019, 1:23 p.m. UTC | #1 
On Fri, Mar 15, 2019 at 03:14:31PM +0100, Philippe Reynes wrote:

> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> 
> Linux commit d45bc58dd3b ("mtd: nand: import nand_hw_control_init()")
> 
> The code to initialize a struct nand_hw_control is duplicated across
> several drivers. Factorize it using an inline function.
> 
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> [Philippe Reynes: adapt code to u-boot and only keep new function]
> 
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index e2bd598..96b5847 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -499,6 +499,13 @@  struct nand_hw_control {
 	struct nand_chip *active;
 };
 
+static inline void nand_hw_control_init(struct nand_hw_control *nfc)
+{
+	nfc->active = NULL;
+	spin_lock_init(&nfc->lock);
+	init_waitqueue_head(&nfc->wq);
+}
+
 /**
  * struct nand_ecc_step_info - ECC step information of ECC engine
  * @stepsize: data bytes per ECC step