| Message ID | 20190314163725.7918-2-jbrunet@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: meson: add g12a drive strength support | expand |
On Thu, Mar 14, 2019 at 05:37:24PM +0100, Jerome Brunet wrote: > From: Guillaume La Roque <glaroque@baylibre.com> > > Add optional drive-strength property > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > index a47dd990a8d3..4e3d5a27c91c 100644 > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > @@ -51,6 +51,9 @@ Configuration nodes support the generic properties "bias-disable", > "bias-pull-up" and "bias-pull-down", described in file > pinctrl-bindings.txt > > +Optional properties : > + - drive-strength: Drive strength for the specified pins in uA. The standard definition says this is in mA. > + > === Example === > > pinctrl: pinctrl@c1109880 { > -- > 2.20.1 >
On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote: > On Thu, Mar 14, 2019 at 05:37:24PM +0100, Jerome Brunet wrote: > > From: Guillaume La Roque <glaroque@baylibre.com> > > > > Add optional drive-strength property > > > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com> > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > --- > > Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > index a47dd990a8d3..4e3d5a27c91c 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > > @@ -51,6 +51,9 @@ Configuration nodes support the generic properties "bias-disable", > > "bias-pull-up" and "bias-pull-down", described in file > > pinctrl-bindings.txt > > > > +Optional properties : > > + - drive-strength: Drive strength for the specified pins in uA. > > The standard definition says this is in mA. Yes, the problem we have and the solutions we are thinking about are explained in detail in the cover letter of this patchset. Could you share your opinion on it ? Thx > > > + > > === Example === > > > > pinctrl: pinctrl@c1109880 { > > -- > > 2.20.1 > >
On Sun, Mar 31, 2019 at 2:04 PM Jerome Brunet <jbrunet@baylibre.com> wrote: > On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote: > > On Thu, Mar 14, 2019 at 05:37:24PM +0100, Jerome Brunet wrote: > > > From: Guillaume La Roque <glaroque@baylibre.com> > > > +Optional properties : > > > + - drive-strength: Drive strength for the specified pins in uA. > > > > The standard definition says this is in mA. > > Yes, the problem we have and the solutions we are thinking about are explained > in detail in the cover letter of this patchset. Could you share your opinion > on it ? I like your idea with drive-strength-uA but I need the second opinion from the device tree people. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt index a47dd990a8d3..4e3d5a27c91c 100644 --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt @@ -51,6 +51,9 @@ Configuration nodes support the generic properties "bias-disable", "bias-pull-up" and "bias-pull-down", described in file pinctrl-bindings.txt +Optional properties : + - drive-strength: Drive strength for the specified pins in uA. + === Example === pinctrl: pinctrl@c1109880 {