| Message ID | 1552543116-21868-4-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 344db3f3307de7c852a0d112c4553a1161c108e7 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Let's write correct arch/*/dts/Makefile | expand |
Am 14.03.19 um 06:58 schrieb Masahiro Yamada: > Since commit 27cb7300ffda ("Ensure device tree DTS is compiled"), > build succeeds irrespective of the correctness of Makefile. > > In fact, you can compile any defconfig without adding any entry in > arch/*/dts/Makefile. > > I am going to revert that commit, so device tree must be explicitly > listed in Makefile. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/mips/dts/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
On Thu, Mar 14, 2019 at 02:58:35PM +0900, Masahiro Yamada wrote: > Since commit 27cb7300ffda ("Ensure device tree DTS is compiled"), > build succeeds irrespective of the correctness of Makefile. > > In fact, you can compile any defconfig without adding any entry in > arch/*/dts/Makefile. > > I am going to revert that commit, so device tree must be explicitly > listed in Makefile. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> Applied to u-boot/master, thanks!
diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile index b94b582..665d3cc 100644 --- a/arch/mips/dts/Makefile +++ b/arch/mips/dts/Makefile @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0+ +dtb-$(CONFIG_ARCH_MT7620) += \ + gardena-smart-gateway-mt7688.dtb \ + linkit-smart-7688.dtb dtb-$(CONFIG_TARGET_AP121) += ap121.dtb dtb-$(CONFIG_TARGET_AP143) += ap143.dtb dtb-$(CONFIG_TARGET_BOSTON) += img,boston.dtb @@ -17,6 +20,8 @@ dtb-$(CONFIG_BOARD_NETGEAR_DGND3700V2) += netgear,dgnd3700v2.dtb dtb-$(CONFIG_BOARD_SAGEM_FAST1704) += sagem,f@st1704.dtb dtb-$(CONFIG_BOARD_TPLINK_WDR4300) += tplink_wdr4300.dtb dtb-$(CONFIG_TARGET_JZ4780_CI20) += ci20.dtb +dtb-$(CONFIG_SOC_BMIPS_BCM6358) += sfr,nb4-ser.dtb +dtb-$(CONFIG_SOC_BMIPS_BCM6838) += brcm,bcm968380gerg.dtb dtb-$(CONFIG_SOC_LUTON) += luton_pcb090.dtb luton_pcb091.dtb dtb-$(CONFIG_SOC_OCELOT) += ocelot_pcb120.dtb ocelot_pcb123.dtb dtb-$(CONFIG_SOC_JR2) += jr2_pcb110.dtb jr2_pcb111.dtb serval2_pcb112.dtb
Since commit 27cb7300ffda ("Ensure device tree DTS is compiled"), build succeeds irrespective of the correctness of Makefile. In fact, you can compile any defconfig without adding any entry in arch/*/dts/Makefile. I am going to revert that commit, so device tree must be explicitly listed in Makefile. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/mips/dts/Makefile | 5 +++++ 1 file changed, 5 insertions(+)