[CIFS] Remove unneeded statements pointed out by Coverity
diff mbox series

Message ID CAH2r5muaceyqkrbXB7Bt-qv_vtVqZEmpafJa6B2+8kyRsK7ftQ@mail.gmail.com
State New
Headers show
Series
  • [CIFS] Remove unneeded statements pointed out by Coverity
Related show

Commit Message

Steve French March 13, 2019, 9:53 p.m. UTC
cifs: remove unused value pointed out by Coverity

Detected by CoverityScan CID#1438719 ("Unused Value")

buf is reset again before being used so these two lines of code
are useless.

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/connect.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

ronnie sahlberg March 13, 2019, 10:14 p.m. UTC | #1
reviewed by me

On Thu, Mar 14, 2019 at 7:53 AM Steve French <smfrench@gmail.com> wrote:
>
> cifs: remove unused value pointed out by Coverity
>
> Detected by CoverityScan CID#1438719 ("Unused Value")
>
> buf is reset again before being used so these two lines of code
> are useless.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/connect.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b95db2b593cb..a8e9738db691 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
>              continue;
>          }
>
> -        if (server->large_buf)
> -            buf = server->bigbuf;
> -
> -
>          server->lstrp = jiffies;
>
>          for (i = 0; i < num_mids; i++) {
>
> --
> Thanks,
>
> Steve

Patch
diff mbox series

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b95db2b593cb..a8e9738db691 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1191,10 +1191,6 @@  cifs_demultiplex_thread(void *p)
             continue;
         }

-        if (server->large_buf)
-            buf = server->bigbuf;
-
-
         server->lstrp = jiffies;

         for (i = 0; i < num_mids; i++) {