[v5,4/5] Acceptance tests: depend on qemu-img
diff mbox series

Message ID 20190313204611.21041-5-crosa@redhat.com
State New
Headers show
  • Add "boot_linux" acceptance test
Related show

Commit Message

Cleber Rosa March 13, 2019, 8:46 p.m. UTC
Tests using the avocado.utils.vmimage library make use of qemu-img,
and because it makes sense to use the version matching the rest of the
source code, let's make sure it gets built.

Its selection, instead of a possible qemu-img binary installed system
wide, is already dealt with by the change that adds the build dir to
the PATH during the test execution.

This is based on the same work for qemu-iotests, and suggested by its

  - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html

CC: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 546c101a14..77d71086f3 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1159,7 +1159,7 @@  $(TESTS_RESULTS_DIR):
 check-venv: $(TESTS_VENV_DIR)
-check-acceptance: check-venv $(TESTS_RESULTS_DIR)
+check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF)
 	$(call quiet-command, \
             $(TESTS_VENV_DIR)/bin/python -m avocado \
             --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \