diff mbox series

qcow2: Fix data file error condition in qcow2_co_create()

Message ID 20190313142519.29749-1-kwolf@redhat.com
State New
Headers show
Series qcow2: Fix data file error condition in qcow2_co_create() | expand

Commit Message

Kevin Wolf March 13, 2019, 2:25 p.m. UTC 
We were trying to check whether bdrv_open_blockdev_ref() returned
success, but accidentally checked the wrong variable. Spotted by
Coverity (CID 1399703).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake March 13, 2019, 2:32 p.m. UTC | #1 
On 3/13/19 9:25 AM, Kevin Wolf wrote:
> We were trying to check whether bdrv_open_blockdev_ref() returned
> success, but accidentally checked the wrong variable. Spotted by
> Coverity (CID 1399703).
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 0fc9b0561e..20aba3a4d6 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3073,7 +3073,7 @@ qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp)
>              goto out;
>          }
>          data_bs = bdrv_open_blockdev_ref(qcow2_opts->data_file, errp);
> -        if (bs == NULL) {
> +        if (data_bs == NULL) {
>              ret = -EIO;
>              goto out;
>          }
>
Stefano Garzarella March 14, 2019, 9:17 a.m. UTC | #2 
On Wed, Mar 13, 2019 at 03:25:19PM +0100, Kevin Wolf wrote:
> We were trying to check whether bdrv_open_blockdev_ref() returned
> success, but accidentally checked the wrong variable. Spotted by
> Coverity (CID 1399703).
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
diff mbox series

Patch

diff --git a/block/qcow2.c b/block/qcow2.c
index 0fc9b0561e..20aba3a4d6 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3073,7 +3073,7 @@  qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp)
             goto out;
         }
         data_bs = bdrv_open_blockdev_ref(qcow2_opts->data_file, errp);
-        if (bs == NULL) {
+        if (data_bs == NULL) {
             ret = -EIO;
             goto out;
         }