Patchwork sparc,kgdbts: fix compile regression with kgdb test suite

login
register
mail settings
Submitter Jason Wessel
Date July 19, 2011, 8:58 p.m.
Message ID <1311109112-12909-1-git-send-email-jason.wessel@windriver.com>
Download mbox | patch
Permalink /patch/105540/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jason Wessel - July 19, 2011, 8:58 p.m.
Commit 63ab25ebbc (kgdbts: unify/generalize gdb breakpoint adjustment)
introduced a compile regression on sparc.

kgdbts.c: In function 'check_and_rewind_pc':
kgdbts.c:307: error: implicit declaration of function 'instruction_pointer_set'

Simply add the correct macro definition for instruction pointer on the
Sparc architecture.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 arch/sparc/include/asm/ptrace.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Mike Frysinger - July 19, 2011, 9:06 p.m.
On Tue, Jul 19, 2011 at 16:58, Jason Wessel wrote:
> Commit 63ab25ebbc (kgdbts: unify/generalize gdb breakpoint adjustment)
> introduced a compile regression on sparc.
>
> kgdbts.c: In function 'check_and_rewind_pc':
> kgdbts.c:307: error: implicit declaration of function 'instruction_pointer_set'
>
> Simply add the correct macro definition for instruction pointer on the
> Sparc architecture.

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - July 21, 2011, 9:45 p.m.
From: Jason Wessel <jason.wessel@windriver.com>
Date: Tue, 19 Jul 2011 15:58:32 -0500

> Commit 63ab25ebbc (kgdbts: unify/generalize gdb breakpoint adjustment)
> introduced a compile regression on sparc.
> 
> kgdbts.c: In function 'check_and_rewind_pc':
> kgdbts.c:307: error: implicit declaration of function 'instruction_pointer_set'
> 
> Simply add the correct macro definition for instruction pointer on the
> Sparc architecture.
> 
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

Acked-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/include/asm/ptrace.h b/arch/sparc/include/asm/ptrace.h
index c7ad3fe..b928b31 100644
--- a/arch/sparc/include/asm/ptrace.h
+++ b/arch/sparc/include/asm/ptrace.h
@@ -205,6 +205,7 @@  do {	current_thread_info()->syscall_noerror = 1; \
 } while (0)
 #define user_mode(regs) (!((regs)->tstate & TSTATE_PRIV))
 #define instruction_pointer(regs) ((regs)->tpc)
+#define instruction_pointer_set(regs, val) ((regs)->tpc = (val))
 #define user_stack_pointer(regs) ((regs)->u_regs[UREG_FP])
 #define regs_return_value(regs) ((regs)->u_regs[UREG_I0])
 #ifdef CONFIG_SMP