From patchwork Tue Mar 12 12:09:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 1055346 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=orange.com Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44JYh95jbwz9sBp for ; Tue, 12 Mar 2019 23:10:17 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6DDE887C3F; Tue, 12 Mar 2019 12:10:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id la5-h7itBEwg; Tue, 12 Mar 2019 12:10:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id B6F098757D; Tue, 12 Mar 2019 12:10:05 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BD7AE1BF419 for ; Tue, 12 Mar 2019 12:09:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B22F8872E8 for ; Tue, 12 Mar 2019 12:09:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BIOY27NKXu9K for ; Tue, 12 Mar 2019 12:09:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from orange.com (mta136.mail.business.static.orange.com [80.12.70.36]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3459486963 for ; Tue, 12 Mar 2019 12:09:44 +0000 (UTC) Received: from opfednr03.francetelecom.fr (unknown [xx.xx.xx.67]) by opfednr27.francetelecom.fr (ESMTP service) with ESMTP id 44JYgV63Bkz4wdn; Tue, 12 Mar 2019 13:09:42 +0100 (CET) Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.54]) by opfednr03.francetelecom.fr (ESMTP service) with ESMTP id 44JYgV5KL1zDq80; Tue, 12 Mar 2019 13:09:42 +0100 (CET) Received: from OPEXCLILM6F.corporate.adroot.infra.ftgroup (10.114.31.34) by OPEXCAUBM7D.corporate.adroot.infra.ftgroup (10.114.13.54) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Mar 2019 13:09:42 +0100 Received: from r-lnx-nyma7486-2.rd.francetelecom.fr (10.168.234.2) by OPEXCLILM6F.corporate.adroot.infra.ftgroup (10.114.31.34) with Microsoft SMTP Server id 14.3.439.0; Tue, 12 Mar 2019 13:09:40 +0100 From: To: Date: Tue, 12 Mar 2019 13:09:35 +0100 X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.168.234.2] Message-ID: <17089_1552392582_5C87A186_17089_130_1_f6f2aff0-c673-4b8c-9779-7e671921c77f@OPEXCLILM6F.corporate.adroot.infra.ftgroup> Subject: [Buildroot] [PATCH 4/5 v2] toolchain: -fstack-protector-strong can be back-ported X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Thomas De Schampheleire , Thomas Petazzoni Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: "Yann E. MORIN" Currently, use of -fstack-protector-strong is only available for gcc starting with 4.9, on the assumption that it appeared with that version. Although this is true, it happens that quite a few vendors will have back-ported -fstack-protector-strong to older gcc versions (at least 4.8 seen in the wild). Remove the guard against gcc>=4.9, and expand the help text. Signed-off-by: "Yann E. MORIN" Cc: Matt Weber Cc: Thomas Petazzoni Cc: Thomas De Schampheleire --- Notes: We could have changed the guard to something like: depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || BR2_TOOLCHAIN_EXTERNAL However, the latest gcc we support in the internal toolchain *is* gcc-4.9, so the condition would have always been true. Hence, we just drop the condition. --- Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Config.in b/Config.in index 757ad1ca40..d5a0460f98 100644 --- a/Config.in +++ b/Config.in @@ -746,14 +746,14 @@ config BR2_SSP_REGULAR config BR2_SSP_STRONG bool "-fstack-protector-strong" - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 help Like -fstack-protector but includes additional functions to be protected - those that have local array definitions, or have references to local frame addresses. -comment "Stack Smashing Protection strong needs a toolchain w/ gcc >= 4.9" - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 + -fstack-protector-strong officially appeared in gcc 4.9, but + some vendors have backported -fstack-protector-strong to older + versions of gcc. config BR2_SSP_ALL bool "-fstack-protector-all"